FILE: ...rk/drupal-8/web/modules/contrib/omnystudio/src/OmnyStudioApi.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------
 238 | WARNING | There must be no blank line following an inline
     |         | comment
 264 | WARNING | There must be no blank line following an inline
     |         | comment
 308 | WARNING | There must be no blank line following an inline
     |         | comment
 352 | WARNING | There must be no blank line following an inline
     |         | comment
----------------------------------------------------------------------


FILE: ...b/modules/contrib/omnystudio/src/Commands/OmnyStudioCommands.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 9 WARNINGS AFFECTING 9 LINES
----------------------------------------------------------------------
  77 | WARNING | Unused variable $result.
  81 | WARNING | \Drupal calls should be avoided in classes, use
     |         | dependency injection instead
  84 | WARNING | \Drupal calls should be avoided in classes, use
     |         | dependency injection instead
  97 | WARNING | \Drupal calls should be avoided in classes, use
     |         | dependency injection instead
 103 | WARNING | \Drupal calls should be avoided in classes, use
     |         | dependency injection instead
 116 | WARNING | \Drupal calls should be avoided in classes, use
     |         | dependency injection instead
 122 | WARNING | \Drupal calls should be avoided in classes, use
     |         | dependency injection instead
 135 | WARNING | \Drupal calls should be avoided in classes, use
     |         | dependency injection instead
 141 | WARNING | \Drupal calls should be avoided in classes, use
     |         | dependency injection instead
----------------------------------------------------------------------

Time: 326ms; Memory: 8Mb
CommentFileSizeAuthor
#3 3125559-2.patch5.48 KBkarishmaamin

Comments

shaktik created an issue. See original summary.

karishmaamin’s picture

Assigned: Unassigned » karishmaamin
karishmaamin’s picture

Assigned: karishmaamin » Unassigned
Status: Active » Needs review
StatusFileSize
new5.48 KB

please review

shaktik’s picture

  • nmudgal committed 65ed6da on 1.x
    Issue #3125559 by shaktik: Drupal calls should be avoided in classes,...
nmudgal’s picture

Status: Needs review » Fixed

Thanks guys for the issue and patch. Though the patch had missing arguments, fixed and committed it to dev. Thank you!

nmudgal’s picture

Status: Fixed » Closed (fixed)