Error saving watchdog view after dblog_update_8600()

Problem/Motivation

Splitting this issue from #2998103: dblog_update_8600() breaks views.view.watchdog config entity, leading to PHP warning on admin/reports/dblog and configuration import errors

That issue was covering 2 problems that appear to happen in the update 8.6.0 and possibly involving dblog_update_8600() and a site was installed with a language beside English

1. The user simply went to admin/reports/dblog and encountered an error
2. The user tries to edit the watchdog View at admin/reports/dblog and encountered an error

this issue will cover #2

Steps reproduce

1. git checkout 8.5.5
2. drush sql-drop
3. rm -rf vendor && composer install
4. drush si standard --account-pass=admin --locale=es
5. sign-in in the web
6. git checkout 8.6.0
7. rm -rf vendor && composer install
8. run update.php via web
9. goto admin/reports/dblog
10. edit and save the view

The last step will get the error

El sitio web encontró un error inesperado. Vuelva a intentarlo más tarde.InvalidArgumentException: Placeholders must have a trailing [] if they are to be expanded with an array of values. in Drupal\Core\Database\Connection->expandArguments() (line 729 of core/lib/Drupal/Core/Database/Connection.php).

Drupal\Core\Database\Connection->query('UPDATE {locales_target} SET translation=:db_update_placeholder_0, customized=:db_update_placeholder_1
WHERE (lid = :db_condition_placeholder_0) AND (language = :db_condition_placeholder_1)', Array, Array) (Line: 148)

I step debugged this and interestingly I think in this case it because dblog_update_8600() did not update the view. Because dblog_update_8600 has

  // Only update the empty text if is untouched from the original version.
  if ($empty_text['area']['id'] == 'area' &&
      $empty_text['area']['plugin_id'] == 'text' &&
      $empty_text['area']['field'] == 'area' &&
      $empty_text['area']['content']['value'] == 'No log messages available.') {

The last condition does not pass when installing in Spanish $empty_text['area']['content']['value'] == 'No log messages available.' will not true because this actually has the Spanish translation.

Proposed resolution

This can be repaired from the UI. It may be easier to do if one has the configuration export of views.view.watchdog.yml from before the upgrade. The following uses the default view.

1. Export view.view.watchdog.yml.
2. Find the empty section for the No results behavior. In the default config, in 8.5.5 it starts at line 656.

      empty:
        area:
          id: area
          table: views
          field: area
          relationship: none
          group_type: group
          admin_label: ''
          empty: true
          tokenize: false
          content:
            value: 'Nessun messaggio di log disponibile.'
            format: basic_html
          plugin_id: text

4. Delete the entire section, include the 'empty:'.
5. Import the config
6. Now add back the empty section, with some modifications. These are 'id', 'field', 'admin_label', 'content' and 'plugin_id'. If you have not customized this part of the view then use the following. If it was customized, then changing these fields should enable you to use the UI to make further changes.

      empty:
        area:
          id: area_text_custom
          table: views
          field: area_text_custom
          relationship: none
          group_type: group
          admin_label: 'Nessun messaggio di log disponibile.'
          empty: true
          tokenize: false
          content: 'Nessun messaggio di log disponibile.'
          plugin_id: text_custom

7. Import the config.
8. Do not remove and re-add this plugin. If you do there will be errors in the log. You can follow these steps again.

Remaining tasks

TBD

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

None