We modify the output of the search form submit button within the header in two places (we have separate forms for narrow and wide).

However, the button markup is modified everywhere. This means that when we insert a search block into another region, it will be modified (it should not). In addition, the search form at /search/node is modified (it should not be).

CommentFileSizeAuthor
#4 Снимок экрана 2020-04-13 в 12.47.29.png140.24 KBkostyashupenko
#4 3125328-4.patch2.33 KBkostyashupenko
#2 Снимок экрана 2020-04-10 в 13.52.09.png17.55 KBkostyashupenko
olivero-search-form-content.png55.37 KBmherchel
olivero-header-search.png35.59 KBmherchel

Comments

mherchel created an issue. See original summary.

kostyashupenko’s picture

kostyashupenko
Primary language English
Location Omsk
commented
Issue tags: +Needs design
StatusFileSize
new Снимок экрана 2020-04-10 в 13.52.09.png17.55 KB

I think we need design here.. since not clear which styles are expected.

Maybe we can follow selectbox design and place magnifier button inside of input area?
select/search

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented

My initial thought is we should just have the form revert back to it's default, which is the text "Search".

kostyashupenko’s picture

kostyashupenko
Primary language English
Location Omsk
commented
Status: Active » Needs review
StatusFileSize
new 3125328-4.patch2.33 KB
new Снимок экрана 2020-04-13 в 12.47.29.png140.24 KB

search form

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Needs review » Fixed

Looks great! Committing. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.