Closed (fixed)
Project:
Olivero
Component:
User interface
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
5 Apr 2020 at 14:11 UTC
Updated:
30 Apr 2020 at 13:04 UTC
Jump to comment: Most recent, Most recent file



Comments
Comment #2
andrewmacpherson commentedI'd like to expand the scope of this issue, to the accessibility of the pagination component as a whole. There are more problems here than text contrast.
The current design fails WCAG SC 1.4.1 "Use of Color". It's a level A success criterion, so I'm raising the issue priority to major.
The pager's focus indicator fails WCAG SC 1.4.11 Non-text contrast (level AA). It needs a contrast of 3:1 but #53B0EB only provides a contrast of 2.39:1 against white.
The links are 52px square. This satisfies WCAG SC 2.5.5 Target Size (level AAA) - GOOD.
I'd get rid of them. They don't say anything essential. It could also make it easier to satisfy WCAG Use of Color because:
Comment #3
andrewmacpherson commentedComment #4
andrewmacpherson commentedComment #5
andrewmacpherson commentedComment #6
andrewmacpherson commentedComment #7
andrewmacpherson commentedAdded the problems from #2 to the issue summary. Left the proposed resolution open.
Comment #8
andrewmacpherson commentedComment #9
andrewmacpherson commentedComment #10
mherchelWorked on a video call with @jwitkowski79 and did some design "in the browser".
--color--gray-20Next step is implementing this in an accessible way.
Comment #11
mherchelNote that the design above is still rough and not final.
Comment #12
kostyashupenkoPager desktop:

Pager mobile:

I also have changed focus border-color
--color--blue-70by--color--gray-10to match WCAG contrast standardsAlso ellipsis was added (it is actually default ellipsis of any full-pager in any drupal theme)
Also about that part of code:
We need that
grid-columnfor pagers, but idk if it is right way to fix grid for pager here.Comment #13
kostyashupenkoWe also can use

--color--blue-20for border on focus, it gives contrast 4.91:1 against whiteComment #14
mherchelYeah, I like the blue border IMHO.
Also, instead of the following, you can just attach a
layout--content-mediumCSS class to the pager.I'm working on an interdiff right now.
Comment #15
mherchelUpdated patch.
Comment #16
andrewmacpherson commentedI like the direction in comments #10-15. Nice work.
I also think that blue will be a better colour than black for the focus indicator; links have a blue focus indicator elsewhere.
For the arrow icons, I'd treat them as the same colour as the numbers. I don't see any benefit to using different colours for those; they are both links, and have the same behaviour.
Comment #17
kostyashupenkoLooks good to me @mherchel
Comment #18
mherchelCommitted. Thanks everyone!