Avoid using \Drupal calls in classes and try using dependency injection instead in ContentCloseForm.php file

CommentFileSizeAuthor
#5 patch-applied.png25.12 KBurvashi_vora
#5 after-patch.png43.55 KBurvashi_vora
#5 before-patch.png59.82 KBurvashi_vora
#2 dependency_injection-3124427-2.patch2.19 KBankithashetty

Issue fork content_close-3124427

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ankithashetty created an issue. See original summary.

ankithashetty’s picture

ankithashetty
Location Karnataka, India
commented
Status: Active » Needs review
StatusFileSize
new dependency_injection-3124427-2.patch2.19 KB

Used dependency injection in ContentCloseForm.php file by applying the following patch. Please review the same.

Thank You.

urvashi_vora made their first commit to this issue’s fork.

urvashi_vora’s picture

urvashi_vora commented
Assigned: Unassigned » urvashi_vora

Hi,

I will review this patch.

urvashi_vora’s picture

urvashi_vora commented
StatusFileSize
new before-patch.png59.82 KB
new after-patch.png43.55 KB
new patch-applied.png25.12 KB

Hi,

I reviewed your patch, it applied cleanly. And I can confirm that it resolved the dependency injection issue.
Attaching screenshots.

Moving this issue to RTBC.

Thanks

urvashi_vora’s picture

urvashi_vora commented
urvashi_vora’s picture

urvashi_vora commented
Status: Needs review » Reviewed & tested by the community

  • mahtab_alam committed 8b8e726 on 8.x-1.x 
    Issue #3124427 by urvashi_vora, ankithashetty, mahtab_alam: \Drupal...
mahtab_alam’s picture

mahtab_alam commented
Status: Reviewed & tested by the community » Fixed
urvashi_vora’s picture

urvashi_vora commented
Assigned: urvashi_vora » Unassigned

Thanks for the fix.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.