Drupal 9 is coming, let's make this module ready!

CommentFileSizeAuthor
#5 3124413-4.patch2.8 KBgaurav_drupal
#2 3124413-1.patch458 bytesshaktik

Comments

shaktik created an issue. See original summary.

shaktik’s picture

StatusFileSize
new458 bytes
shaktik’s picture

Status: Active » Needs review
gaurav_drupal’s picture

Assigned: Unassigned » gaurav_drupal
Status: Needs review » Needs work
Issue tags: +Drupal 9 compatibility, +Drupal 9 porting weekend, +DIACWMay2020

The patch applies cleanly, however, the drupal-check report has 1 error:

2/2 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ----------------------------------------------------------------------- 
  Line   src/SingleLanguageNegotiationUrl.php                                   
 ------ ----------------------------------------------------------------------- 
  132    PHPDoc tag @param has invalid value ($path                             
         Path to check.): Unexpected token "$path", expected type at offset 87  
 ------ ----------------------------------------------------------------------- 

also, some Drupal coding standard issues reported by PHPCS:

FILE: single_language_url_prefix.info.yml
-----------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------
 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-----------------------------------------------------------------------------------------------------------


FILE: src/Form/SettingsForm.php
----------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
----------------------------------------------------------------------------
  9 | ERROR   | [x] Doc comment short description must end with a full stop
 35 | ERROR   | [x] Short array syntax must be used to define arrays
 47 | WARNING | [ ] Possible useless method overriding detected
----------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------


FILE: src/SingleLanguageNegotiationUrl.php
---------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
---------------------------------------------------------------------------------------
  76 | ERROR | [x] Space before opening parenthesis of function call prohibited
  99 | ERROR | [x] Multi-line function declarations must define one parameter per line
 126 | ERROR | [ ] Missing parameter type
---------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------
gaurav_drupal’s picture

Assigned: gaurav_drupal » Unassigned
Status: Needs work » Needs review
StatusFileSize
new2.8 KB

Provided the patch, please review.

drupal-check reports:

drupal-check -ad .

2/2 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 [OK] No errors  
nikunjkotecha’s picture

Status: Needs review » Fixed

Thanks for raising the issue and providing patch, merged and released as 2.0.0

kristen pol’s picture

@nikunjkotecha How was the code committed? Normally the commit would show up here. Example: https://www.drupal.org/project/cshs/issues/3111529#comment-13643324

nikunjkotecha’s picture

I was actually looking for it myself before fixing and I'm guessing it has something to do with the new release

https://git.drupalcode.org/project/single_language_url_prefix/-/commit/3...

Along with the fixes I updated the version naming as well to match the new convention and released 2.0.x and 2.0.0 and it shows up there but not here.

kristen pol’s picture

Version: 8.x-1.0 » 2.0.x-dev

Yeah, I put a question about it in Slack and @jungle thought it might be the semantic version versus old versioning. I'll try switching this to 2.0.x-dev and see if that makes it show up though maybe it wouldn't do it after the fact actually. Hmm...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.