Closed (fixed)
Project:
Single Language URL Prefix
Version:
2.0.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
2 Apr 2020 at 10:49 UTC
Updated:
8 Jun 2020 at 07:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
shaktikComment #3
shaktikComment #4
gaurav_drupalThe patch applies cleanly, however, the drupal-check report has 1 error:
also, some Drupal coding standard issues reported by PHPCS:
Comment #5
gaurav_drupalProvided the patch, please review.
drupal-check reports:
Comment #6
nikunjkotechaThanks for raising the issue and providing patch, merged and released as 2.0.0
Comment #7
kristen pol@nikunjkotecha How was the code committed? Normally the commit would show up here. Example: https://www.drupal.org/project/cshs/issues/3111529#comment-13643324
Comment #8
nikunjkotechaI was actually looking for it myself before fixing and I'm guessing it has something to do with the new release
https://git.drupalcode.org/project/single_language_url_prefix/-/commit/3...
Along with the fixes I updated the version naming as well to match the new convention and released 2.0.x and 2.0.0 and it shows up there but not here.
Comment #9
kristen polYeah, I put a question about it in Slack and @jungle thought it might be the semantic version versus old versioning. I'll try switching this to 2.0.x-dev and see if that makes it show up though maybe it wouldn't do it after the fact actually. Hmm...