Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
31 Mar 2020 at 19:41 UTC
Updated:
19 Apr 2020 at 19:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
vernitThanks for your contribution. Kindly, Fix the below items :
Review of the 8.x-1.x branch (commit ea2dcbf):
Your README.txt does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
The INTRODUCTION section is missing.
The REQUIREMENTS section is missing.
The INSTALLATION section is missing.
The CONFIGURATION section is missing.
Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
FILE: ...00000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.txt
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
34 | WARNING | Line exceeds 80 characters; contains 81 characters
--------------------------------------------------------------------------
Time: 1.91 secs; Memory: 4Mb
Comment #3
shaktikComment #4
shaktikComment #5
avpadernoThe task of reviewers is reporting what needs to be changed, not providing patch to fix what another reviewer reported. Also, without any evidence the code has been changed, the status cannot be changed to Needs review, which anyway is task of the user who opened the application.
Comment #6
klausiThanks for your contribution, Ashley!
The code in this project is a bit too short to approve you as general security coverage user, but we can opt into security coverage for the project for you (I did that now). Feel free to get back to use whenever you need security coverage for a new project.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on Slack or IRC in #drupal-contribute. So, come hang out and stay involved!
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Thanks to the dedicated reviewer(s) as well.
Comment #7
klausiFixing credits.
Comment #8
ashleyhazle commentedMany thanks for all your input!
@klausi, I couldn't agree more. Thank you flagging the module, that's all I was hoping for :)