I try to use the Photos module for the first time but when I click on the Photos tab it throws an error and this message appears on the screen

The website encountered an unexpected error. Please try again later.

In the drupal log there is this message in the top, followed by 30 rows more

	Error: Call to a member function getType() on null i _photos_access() (rad 103 av /B64/home/upplyser-nu/public_html/upplyser/web/modules/contrib/photos/photos.module)

The Apache error log says

[Sun Mar 29 22:05:53.327489 2020] [proxy_fcgi:error] [pid 62010] [client 90.46.121.131:49936] AH01071: Got error 'PHP message: Error: Call to a member function getType() on null in /B64/home/upplyser-nu/public_html/upplyser/web/modules/contrib/photos/photos.module on line 103 #0 /B64/home/upplyser-nu/public_html/upplyser/web/modules/contrib/photos/src/Form/PhotosUploadForm.php(119): _photos_access('editAlbum', NULL)\n#1 [internal function]: Drupal\\photos\\Form\\PhotosUploadForm->access(Object(Drupal\\Core\\Session\\AccountProxy))\n#2 /B64/home/upplyser-nu/public_html/upplyser/web/core/lib/Drupal/Core/Access/CustomAccessCheck.php(75): call_user_func_array(Array, Array)\n#3 [internal function]: Drupal\\Core\\Access\\CustomAccessCheck->access(Object(Symfony\\Component\\Routing\\Route), Object(Drupal\\Core\\Routing\\RouteMatch), Object(Drupal\\Core\\Session\\AccountProxy))\n#4 /B64/home/upplyser-nu/public_html/upplyser/web/core/lib/Drupal/Core/Access/AccessManager.php(159): call_user_func_array(Array, Array)\n#5 /B64/home/upplyser-nu/public_html/upplyser/web/core/lib/Drupal/Core/Access/AccessManager.php(135): Drupal\\Core\\Access\\AccessManager-...\n', referer: http://upplyser.nu/node/53/photos-rearrange

Comments

hassebasse created an issue. See original summary.

nathaniel’s picture

nathaniel commented
Status: Active » Postponed (maintainer needs more info)

What version of Drupal core is installed on the site? Currently I'm not able to reproduce the error.

In /modules/contrib/photos/src/Form/PhotosUploadForm.php you could alter line 119 to check if $node is not NULL.

Something like this:

    if ($node && _photos_access('editAlbum', $node)) {
      return AccessResult::allowed();
    }

That will hide the error, but the page will return access denied.

Were there any other errors when the module was first installed? Was there a custom content type already called "photos"? Are you logged in as user 1 or some other user?

hassebasse’s picture

hassebasse commented

Hi

Thanks for answering.

Drupal 8.8.4

The first thing I tried was "Are you logged in as user 1 or some other user?" and the answer is that I was not user 1, but some one else, though I had admin rights.

When changing to user 1 everything work as it should.

So it seem that only user 1 can use the module. Do you have any solution for that?

All the best

Hans

nathaniel’s picture

nathaniel commented

It may be a permissions issue then. I would look at all "photo" permissions for the photos node and photos module permissions. I still can't reproduce the issue. There shouldn't be an error though.

nathaniel’s picture

nathaniel commented

A couple other thoughts (if you haven't already):

1. Check status report: /admin/reports/status (Rebuild permissions)
2. Clear cache

hassebasse’s picture

hassebasse commented

HI

  1. I've given users rights to everything with the word Photos in in
  2. I've rebuilt permissions
  3. I've cleqrd cache

The problem remain.

On top:Plupload does not work

Hans

nathaniel’s picture

nathaniel commented

I'm not sure about plupload. But the original issue indicates that the node does not exist (or it can't find it / can't access it for some reason). Normally it should return page not found.

Are there any other access or privacy modules installed?

Or if there is any custom code that modifies access that would be a good place to test.

hassebasse’s picture

hassebasse commented

Hi

  • There is no custom code
  • I had node_view_permissions installed but took it away

I can't understand why it makes a difference between Admins. User number one works just fine but but why does not other Admins work? How could this be related to rights?

Anyhow, I've delted and reinstalled; but in vain.

Hans

hassebasse’s picture

hassebasse commented

Hi again

I've found something.

  1. From the beginning I have had full access from the n° 1 account with Admin rights.
  2. I then tried with an other account (QUERTY) with full Admin rights : Did not work what ever I did
  3. I then degraded QUERTY from Admin to Logged in User and gave full rights to logged in users : Everything worked fine
  4. I changed from logged in User to Admin : The problem returend.
  5. I created the Groupe Photos and gave it all rights needed for Photos and attached QUERTY to the gorupe while keeping the Admin rights: The problem remained
  6. I took away the Admin rights from QUERTY while keeping the group Photos : All works fine

So Admin rights to any other user than n° 1 blocks Photos and give errors. Isn't that odd?

Hans

nathaniel’s picture

nathaniel commented

That is odd. Thanks for keeping us in the loop. Sounds like you are getting close to figuring this one out.

Still the only thing that comes to mind is some kind of permissions issue.

Core (I think you did all of this already):
/admin/people/permissions
/admin/config/people/accounts (the "Administrator role" can be changed here).
/admin/reports/status
/admin/reports/status/rebuild
/admin/config/development/performance (clear all caches)

If you have the group module installed there can be other more complex permissions:
/admin/group/types/manage/{group_type}/permissions
/admin/group/types/manage/{group_type}/permissions/outsider
/admin/group/types/manage/{group_type}/roles/{group_role}/permissions

I'm running some tests with group installed, but still unable to reproduce. If we can figure out the steps to reproduce the issue that would be best. Either way I might add the code from #2 so it doesn't cause a PHP error.

hassebasse’s picture

hassebasse commented

I will keep you updated but I have to come back a little later, I've spent too much time with it right now. Give me a few days.

It clearly has to do with permissions because while I was experimenting with the user QUERTY and chanching permissins to the groupe Photos, suddenly it all screwed upp again. For the moment I can't say what I did, but I added some permissins and it chrashed, and I couldn't have it running until I started all from the beginning.

To me, being an amateur who doesn't know how to code, it seem to be some permissions not being compatible with each other. I will see if I can figure it out during the WE.

hassebasse’s picture

hassebasse commented

I've found the culprit !!!

I've the setup in Swedish so I will try to find the correct English translation.

When giving permission "Använda administrationssidorna och hjälp" = "Use the administration pages and help" under System, then it goes bad. In my user groupe "Photos" I've multiple times checked and unchecked that box and everytime I check it, it craches.

So "Use the administration pages and help" does only work with User 1 in combination with the Photos module. !!! In other setups the Photos modules thorws errors !!!

Pls let me know when you have fixed this! If you need more info about my setup; pls let me know. If you would be helped by an Admin access to the site, just let me know. For the moment I just use it as a site for learning D8, for a later transfer of my main company site.

Bonne week-end

Hans

nathaniel’s picture

nathaniel commented

Hey, thanks for the updates. If you don't mind, I will take a look at admin access. You can send it with my contact form:
https://www.drupal.org/u/nathaniel

I'm curious if there is anything else in the logs:
/admin/reports/dblog

Anything like: "User warning: The following module is missing from the file system: ..."?

Have a great weekend!

hassebasse’s picture

hassebasse commented

Hi

Did you recive the login details? If you want I can arrange to go in by the commande line, but then I need your IP adress.

Concerning my earlier question about Plupload, I used an old library version, 1.6 something. With that one it was very lilmited when it comes to charachters in the file name. Only small letters and _ could be used. After upgrading to 2.3.6 it works as it should, I can use any charachter in the file name.

Hans

nathaniel’s picture

nathaniel commented
Status: Postponed (maintainer needs more info) » Active

Thanks for sending admin access, that was helpful! After matching some of your site settings and running a few more tests I was finally able to reproduce the issue.

It's something to do with the language settings. I'm not sure exactly what yet:
1. /admin/config/regional/language/detection set "Account administration pages".
2. On user edit (this also happens for user 1 - super admin) select any "Administration pages language" other than no preference.

In the stack trace /admin/reports/dblog/event/68326 (for example) #10 (LanguageNegotiation) is returning access denied for some reason before it reaches the photos access check, so I will add the code from comment#2 above. But, this is still cryptic and doesn't explain why access is denied.

I stumbled on this issue trying to track down the problem from your stack trace:
#2706241: AccessAwareRouter does not respect HTTP method
The patch there does not fix this issue though.

Now the question is why do /edit /photos-rearrange etc. still work fine?

hassebasse’s picture

hassebasse commented

Great that you are making progress! You ended with a question mark, but I hope you don't expect an answer from me as I don't know coding very much at all.

As you have been able to reproduce the issue, can I assume you don't need the access any more?

Hans

nathaniel’s picture

nathaniel commented

Actually yes, the code from #2 fixes the issue. Odd. Okay, I'll get that submitted here shortly. After that is committed you can install the latest dev version 8.x-4.x dev, clear cache and it should be good to go.

Thanks for your help reporting / debugging the issue!

hassebasse’s picture

hassebasse commented

You are welcome, it was my plesure.

  • Nathaniel committed 8f5fa2c on 8.x-4.x 
    Issue #3123334 by hassebasse, Nathaniel: The Photos tab throws an error...

  • Nathaniel committed 04b76a9 on 8.x-4.x 
    Issue #3123334 by hassebasse, Nathaniel: The Photos tab throws an error...
nathaniel’s picture

nathaniel commented
Status: Active » Fixed

No longer need access thanks!

hassebasse’s picture

hassebasse commented

I have upgraded and it works perfectly. Well done!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.