The check has some problems, like not being able to detect dev versions/git checkouts without additional modules. And it serves no purpose in 9.0 plus,

Comments

Berdir created an issue. See original summary.

berdir’s picture

The check is in system_requirements()

neslee canil pinto’s picture

Status: Active » Needs review
StatusFileSize
new968 bytes
berdir’s picture

Status: Needs review » Needs work

Now you basically make it always fail. You should remove the whole block.

neslee canil pinto’s picture

Status: Needs work » Needs review
StatusFileSize
new1.21 KB
berdir’s picture

Status: Needs review » Reviewed & tested by the community

I doubt we have tests for this, so if this passes then it's IMHO good to go. This currently makes D9 testing harder as it doesn't handle dev version, which you currently need of pathauto and it's duplicated by the core-compatibility check now as these old versions are not D9 compatible anyway. This D9 only.

berdir’s picture

Status: Reviewed & tested by the community » Needs work

Actually, that's not all, there's also a conflict definition in composer.json that we can remove.

neslee canil pinto’s picture

Status: Needs work » Needs review
StatusFileSize
new1.51 KB

Status: Needs review » Needs work

The last submitted patch, 8: 3123326-8.patch, failed testing. View results

neslee canil pinto’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 8: 3123326-8.patch, failed testing. View results

berdir’s picture

this means we need to update the composer lock hash, try composer update --lock with the patch applied.

neslee canil pinto’s picture

Status: Needs work » Needs review
StatusFileSize
new5.94 KB
neslee canil pinto’s picture

StatusFileSize
new3.3 KB
catch’s picture

Status: Needs review » Needs work

Needs another re-roll.

neslee canil pinto’s picture

Status: Needs work » Needs review
StatusFileSize
new1.87 KB

Status: Needs review » Needs work

The last submitted patch, 16: 3123326-16.patch, failed testing. View results

neslee canil pinto’s picture

StatusFileSize
new4 KB
longwave’s picture

Version: 9.0.x-dev » 9.1.x-dev
Status: Needs work » Needs review
StatusFileSize
new2.2 KB

To update the composer.lock hash I applied #16 and then ran

COMPOSER_ROOT_VERSION=9.1.x-dev composer update drupal/core
neslee canil pinto’s picture

StatusFileSize
new2.2 KB

Status: Needs review » Needs work

The last submitted patch, 20: 3123326-20.patch, failed testing. View results

berdir’s picture

Status: Needs work » Reviewed & tested by the community

Was a random fail. Looks good now. patch is for 9.1.x now, I think this can also be done on 9.0, but apparently will require a reroll for that?

  • catch committed 01ab625 on 9.1.x
    Issue #3123326 by Neslee Canil Pinto, longwave, Berdir: Remove pathauto...
catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 9.1.x, thanks!

Yes 9.0.x has a different lock hash, so every change needs a specific backport. I think it's OK if we only commit this to 9.1.x, it's not really doing any harm, but if someone wants to work on a backport, please re-open for 9.0.x with a patch.

berdir’s picture

> it's not really doing any harm

It kinda does, because you get errors about pathauto being incompatible if you test D9 with pathauto 8.x-1.x-dev right now, which is the only compatible version. But I'll do a new release soon, that will solve that problem as well.

catch’s picture

Version: 9.1.x-dev » 9.0.x-dev
Status: Fixed » Patch (to be ported)

Oh I did not realise that, well let's backport if we can then.

neslee canil pinto’s picture

StatusFileSize
new2.2 KB

Patch for 9.0.x

neslee canil pinto’s picture

Status: Patch (to be ported) » Needs review
longwave’s picture

Status: Needs review » Reviewed & tested by the community

Same patch, different hash, hash test passes => RTBC

  • catch committed c8108b8 on 9.0.x
    Issue #3123326 by Neslee Canil Pinto, longwave, Berdir: Remove pathauto...
catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed c8108b8 and pushed to 9.0.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.