The check has some problems, like not being able to detect dev versions/git checkouts without additional modules. And it serves no purpose in 9.0 plus,
| Comment | File | Size | Author |
|---|---|---|---|
| #27 | 3123326-27.patch | 2.2 KB | neslee canil pinto |
| #20 | 3123326-20.patch | 2.2 KB | neslee canil pinto |
| #19 | 3123326-19.patch | 2.2 KB | longwave |
Comments
Comment #2
berdirThe check is in system_requirements()
Comment #3
neslee canil pintoComment #4
berdirNow you basically make it always fail. You should remove the whole block.
Comment #5
neslee canil pintoComment #6
berdirI doubt we have tests for this, so if this passes then it's IMHO good to go. This currently makes D9 testing harder as it doesn't handle dev version, which you currently need of pathauto and it's duplicated by the core-compatibility check now as these old versions are not D9 compatible anyway. This D9 only.
Comment #7
berdirActually, that's not all, there's also a conflict definition in composer.json that we can remove.
Comment #8
neslee canil pintoComment #10
neslee canil pintoComment #12
berdirthis means we need to update the composer lock hash, try composer update --lock with the patch applied.
Comment #13
neslee canil pintoComment #14
neslee canil pintoComment #15
catchNeeds another re-roll.
Comment #16
neslee canil pintoComment #18
neslee canil pintoComment #19
longwaveTo update the composer.lock hash I applied #16 and then ran
Comment #20
neslee canil pintoComment #22
berdirWas a random fail. Looks good now. patch is for 9.1.x now, I think this can also be done on 9.0, but apparently will require a reroll for that?
Comment #24
catchCommitted/pushed to 9.1.x, thanks!
Yes 9.0.x has a different lock hash, so every change needs a specific backport. I think it's OK if we only commit this to 9.1.x, it's not really doing any harm, but if someone wants to work on a backport, please re-open for 9.0.x with a patch.
Comment #25
berdir> it's not really doing any harm
It kinda does, because you get errors about pathauto being incompatible if you test D9 with pathauto 8.x-1.x-dev right now, which is the only compatible version. But I'll do a new release soon, that will solve that problem as well.
Comment #26
catchOh I did not realise that, well let's backport if we can then.
Comment #27
neslee canil pintoPatch for 9.0.x
Comment #28
neslee canil pintoComment #29
longwaveSame patch, different hash, hash test passes => RTBC
Comment #31
catchCommitted c8108b8 and pushed to 9.0.x. Thanks!