Problem/Motivation

Follow up #2729597: [meta] Replace \Drupal with injected services where appropriate in core

Proposed resolution

Replace all of them with IoC injection where possible

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#12 3123223-12.patch6.19 KBranjith_kumar_k_u
#5 interdiff-4-5.txt2.26 KBhardik_patel_12
#5 3123223-5.patch6.66 KBhardik_patel_12
#4 3123223-4.patch6.04 KBhardik_patel_12

Comments

jungle created an issue. See original summary.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

hardik_patel_12’s picture

hardik_patel_12 commented
Assigned: Unassigned » hardik_patel_12
hardik_patel_12’s picture

hardik_patel_12 commented
Assigned: hardik_patel_12 » Unassigned
Status: Active » Needs review
StatusFileSize
new 3123223-4.patch6.04 KB

Kindly review a patch.

hardik_patel_12’s picture

hardik_patel_12 commented
StatusFileSize
new 3123223-5.patch6.66 KB
new interdiff-4-5.txt2.26 KB

Adding change record and deprecation error also. Kindly review a new patch.

jungle’s picture

jungle
He/Him
Location Chongqing, China
commented
Title: Replace usages of \Drupal::moduleHandler() with IoC injection » Replace non-test usages of \Drupal::moduleHandler() with IoC injection

We do this for non-test code under this issue.

Per the parent issue, rescoping this to do it for non-test code.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

ranjith_kumar_k_u’s picture

ranjith_kumar_k_u commented
StatusFileSize
new 3123223-12.patch6.19 KB

Rerolled #5 for 10.1

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Looks like a good coding standard to follow. See no failures for 10.1 so would say it's good.

Though please upload an interdiff when uploading a new patch. Even rerolls can have some difference.

  • catch committed 5e4462f on 10.1.x 
    Issue #3123223 by Hardik_Patel_12, ranjith_kumar_k_u, jungle: Replace...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 10.1.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

quietone’s picture

quietone commented

Updated CR and published.