Some issues:

- Class should match filename, now we have HumansTxtAdminSettingsForm and HumanstxtSettingsForm, we should be consistent (this is the main issue)
- getFormID should be getFormId instead
- Short description of the class should be one line, so there's a line break missing between lines 10 and 11.
- getEditableConfigNames() has @inheritDoc when it should be {@inheritdoc}
- Missing comma on the return array on getEditableConfigNames()
- Markup on "humanstxt_about", has a concatenation issue, translatable string should not have dots on it to get the
in
- Some indentation and array line breaks on the humanstxt_about key.

Comments

pcambra created an issue. See original summary.

davidjguru’s picture

Assigned: Unassigned » davidjguru
davidjguru’s picture

Ok, I made a patch with all the items from a code review. Now with all the changes contained in the patch, phpcs --standard=Drupal and phpcs --standard=DrupalPractice are returning zero results both.

I hope this works fine.

Greetings,

David.

davidjguru’s picture

Assigned: davidjguru » Unassigned
Status: Active » Needs review

  • pcambra committed e1f894b on 8.x-1.x authored by davidjguru
    Issue #3123133 by davidjguru: Review coding standards on...
pcambra’s picture

Status: Needs review » Fixed

Looks great, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.