I'd like to refactor the module code into separate classes, and call those within override_node_options_form_alter() and override_node_options_entity_field_access_alter().

This should also highlight any code that isn't covered by the existing tests.

CommentFileSizeAuthor
#10 3122619-10.patch13.68 KBopdavies
#9 3122619-9.patch14.23 KBopdavies
#8 3122619-8.patch12.43 KBopdavies
#7 interdiff-5-7.txt9.95 KBopdavies
#7 3122619-7.patch12.43 KBopdavies
#5 refactor_hooks_code-3122619-5.patch12.46 KBmarcosdr
#4 refactor_hooks_code-3122619-3.patch0 bytesmarcosdr
#2 refactor_hooks_code-3122619-2.patch12.72 KBmarcosdr

Comments

opdavies created an issue. See original summary.

marcosdr’s picture

marcosdr commented
StatusFileSize
new refactor_hooks_code-3122619-2.patch12.72 KB

Refactor module hooks code into separate classes for field control access.

opdavies’s picture

opdavies
He/him
Primary language English
Location Wales
commented
Status: Active » Needs review
marcosdr’s picture

marcosdr commented
StatusFileSize
new refactor_hooks_code-3122619-3.patch0 bytes
marcosdr’s picture

marcosdr commented
StatusFileSize
new refactor_hooks_code-3122619-5.patch12.46 KB
opdavies’s picture

opdavies
He/him
Primary language English
Location Wales
commented
opdavies’s picture

opdavies
He/him
Primary language English
Location Wales
commented
StatusFileSize
new 3122619-7.patch12.43 KB
new interdiff-5-7.txt9.95 KB

Fixed some coding standards issues.

opdavies’s picture

opdavies
He/him
Primary language English
Location Wales
commented
StatusFileSize
new 3122619-8.patch12.43 KB
opdavies’s picture

opdavies
He/him
Primary language English
Location Wales
commented
StatusFileSize
new 3122619-9.patch14.23 KB
opdavies’s picture

opdavies
He/him
Primary language English
Location Wales
commented
StatusFileSize
new 3122619-10.patch13.68 KB
opdavies’s picture

opdavies
He/him
Primary language English
Location Wales
commented

#10 fixes all of the coding standards issues that were added in earlier patches.

  • opdavies committed 0c947df on 8.x-2.x authored by marcosdr 
    Issue #3122619 by opdavies, marcosdr: Refactor the module code into...

  • opdavies committed 8604b85 on 8.x-3.x authored by marcosdr 
    Issue #3122619 by opdavies, marcosdr: Refactor the module code into...
opdavies’s picture

opdavies
He/him
Primary language English
Location Wales
commented
Status: Needs review » Fixed

Thanks @marcosdr!

opdavies’s picture

opdavies
He/him
Primary language English
Location Wales
commented
Assigned: opdavies » Unassigned

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.