var messages_left = $('.messages__wrapper').children().size();

If children returns null, this fails with:

messageclose.js?v=1:16 Uncaught TypeError: $(...).children(...).size is not a function
    at HTMLDivElement.<anonymous> (messageclose.js?v=1:16)
    at HTMLDivElement.d.complete (jquery.min.js?v=3.2.1:3)
CommentFileSizeAuthor
#2 3121802-2.patch839 bytesanisha.challa

Comments

penyaskito created an issue. See original summary.

anisha.challa’s picture

anisha.challa commented
Status: Active » Needs review
StatusFileSize
new 3121802-2.patch839 bytes

Hi,

I have atatched a patch. Please review the same.

Thanks.

Christopher Riley’s picture

Christopher Riley commented

Thank you for the patch it cleared up an issue that I was having.

malaynayak’s picture

malaynayak commented
Status: Needs review » Reviewed & tested by the community
malaynayak’s picture

malaynayak commented

patch #2 looks good.

bwaindwain’s picture

bwaindwain commented

looks good

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

I've used this myself on production for a long time.
Committed and pushed to 8.x-1.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.