Add core_version_requirement: ^8 || ^9 to permissions_by_term.info.yml to designate that the module is compatible with Drupal 9. See https://www.drupal.org/node/3070687.

CommentFileSizeAuthor
#4 3121522-4.patch1.09 KBjungle
#3 3121522-3.patch383 byteshussainweb

Comments

hussainweb created an issue. See original summary.

hussainweb’s picture

hussainweb
Primary language English
commented
Issue summary: View changes
hussainweb’s picture

hussainweb
Primary language English
commented
Version: 8.x-1.x-dev » 8.x-2.18
Status: Active » Needs review
StatusFileSize
new 3121522-3.patch383 bytes
jungle’s picture

jungle
He/Him
Location Chongqing, China
commented
StatusFileSize
new 3121522-4.patch1.09 KB

Should add the key to submodule too

jungle’s picture

jungle
He/Him
Location Chongqing, China
commented

@itamair
Does this adaption to Drupal 9 need to be added into all modules submodules too?

core_version_requirement: ^8 || ^9

@dan2k3k4
Yeah, all modules/submodules/themes require the new key as the old one is deprecated/isn't used for D9

@berdir
yeah. technically, for drupal, there are no such things as "submodules", all modules are equal, they might just be within another module. The only exception are test module, if they're in the testing package then it is possible to leave out both keys and it will then automatically set it. but that requires at least drupal 8.8.3 or so

-- conversations on slack

hussainweb’s picture

hussainweb
Primary language English
commented
Status: Needs review » Needs work 
+++ b/modules/permissions_by_entity/permissions_by_entity.info.yml
@@ -2,6 +2,7 @@ name: 'Permissions by Entity'
-package: 'Permissions by Term (Experimental)'
\ No newline at end of file
+package: 'Permissions by Term (Experimental)'

It seems the newline was accidentally removed here.

jungle’s picture

jungle
He/Him
Location Chongqing, China
commented
Status: Needs work » Needs review

In fact, no newline originally, The patch added a newline.

hussainweb’s picture

hussainweb
Primary language English
commented

Ah, okay. My bad.

marcoliver’s picture

marcoliver
he/him
Primary language German
Location Neuss, NRW, Germany
commented
Status: Needs review » Closed (outdated)

Closing as outdated, since we're way past Drupal 9 at this point.