CommentFileSizeAuthor
#3 commerce_xattributes-drupal-9-compatibility-3121301-3.patch6.07 KBnickolaj
#2 3121301-2.patch420 bytesneslee canil pinto

Comments

Neslee Canil Pinto created an issue. See original summary.

neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new 3121301-2.patch420 bytes
nickolaj’s picture

nickolaj
Primary language Ukrainian
commented
StatusFileSize
new commerce_xattributes-drupal-9-compatibility-3121301-3.patch6.07 KB 
drupal-check commerce_xattributes
 13/13 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ -------------------------------------------------------------------------------------------------------
  Line   modules/commerce_cattributes/src/Plugin/Field/FieldWidget/CorrectProductVariationAttributesWidget.php
 ------ -------------------------------------------------------------------------------------------------------
  398    Call to deprecated function entity_get_form_display().
  405    Call to deprecated function entity_get_form_display().
 ------ -------------------------------------------------------------------------------------------------------

 ------ ------------------------------------------------------------------------------
  Line   src/Form/XattributesProductVariationTypeForm.php
 ------ ------------------------------------------------------------------------------
  30     Call to deprecated method url() of class Drupal\Core\Entity\EntityInterface.
 ------ ------------------------------------------------------------------------------

 ------ --------------------------------------------------------------------------------------------------------------
  Line   tests/src/Functional/XattributesProductAttributeTest.php
 ------ --------------------------------------------------------------------------------------------------------------
         Class Drupal\Tests\commerce_product\Functional\ProductBrowserTestBase not found and could not be autoloaded.

Please review a patch.

  • nickolaj authored e11c538 on 8.x-1.x 
    Issue #3121301 by Neslee Canil Pinto, nickolaj: Compatibility with...
drugan’s picture

drugan commented
Status: Needs review » Fixed

Thanks, guys!

@Neslee Canil Pinto unfortunately, I can't give you commit credit for you patch because adding just one line into the .info.yml file does not actually fix the compatibility issue. There should be run drupal-check and resolved all the errors in the output of this command. Like @nickolaj did it.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.