This module adds a node edit (and taxonomy term edit) button into the admin toolbar.

Configuration

Currently, after activating the module you have to go to "Structure > Block layout > Tabs (block) > Configure" and in "Visibility (vertical tab) > Pages" set " Hide for the listed pages" and for Pages

/node/*
/taxonomy/term/*

This way you would remove the "Local tasks tabs" from the node view (node detail) and taxonomy term view (taxonomy term detail) pages and you will have just the "Edit" button in the admin toolbar (up, right).
Also, make sure you don't have the Quick Edit and
Contextual Links modules activated.

Project link

https://www.drupal.org/project/toolbar_edit_button

Git instructions

git clone --branch 8.x-1.x https://git.drupalcode.org/project/toolbar_edit_button.git

PAReview checklist

https://pareview.sh/pareview/https-git.drupal.org-project-toolbar_edit_b...

Comments

Nikolay Borisov created an issue. See original summary.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
Issue tags: -PAreview: security, -PAreview: review bonus +PAreview: project created less than ten days ago

Thank you for applying! I added the Git instructions for non-maintainer users and the PAReview checklist link. Reviewers will check the project and post comments to list what should be changed.

If you haven't done it, yet, please check the PAReview report and fix what needs to be fixed. There could be some false positives; verify that what reported is correct, before making any change.

Also, remember to change status, when the project is ready to be reviewed. The current status is telling reviewers not to review the project.

nikolay borisov’s picture

nikolay borisov commented

Thanks a lot, kiamlaluno!

I will fix those small things and I will change the status of this ticket to "Needs review"

Cheers!

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Active » Fixed
Issue tags: -PAreview: project created less than ten days ago
  1. toolbar_edit_button.services.yml: the class EditButtonService does not exist? Should this be ToolbarHandler?
  2. toolbar_edit_button_toolbar(): don't use the class resolver here, use \Drupal::service() once you fixed your services.yml file.

Otherwise looks good to me.

Thanks for your contribution, Nikolay!

I updated your account so you can opt into security advisory coverage now.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

nikolay borisov’s picture

nikolay borisov commented

Hi klausi!

Thanks a lot for your input!

Actually initially it was a service, that I called directly with \Drupal::service() in hook_toolbar() and then I switched to class_resolver + Class name change. At the same time, phpcs and phpmd did not find the unused services.yml file so that's why I missed it.

Thanks a lot! I will fix the suggestions from klausi + the PAReview suggestions.

Cheers and have a nice day,
Nikolay

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.