Problem/Motivation

#3109480: Properly deprecate theme functions for Drupal 10 deprecated theme functions for Drupal 10.
However, it can be hard to know which function is the offending one in test results.
Especially if it is coming from a dependency of your module, and not the module itself.

Proposed resolution

Add the function name to the deprecation message

Remaining tasks

N/A

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

CommentFileSizeAuthor
#2 3120954-themedep-2.patch3.63 KBtim.plunkett

Comments

tim.plunkett created an issue. See original summary.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs review
StatusFileSize
new 3120954-themedep-2.patch3.63 KB
czigor’s picture

czigor commented
Status: Needs review » Reviewed & tested by the community

Works for me, thanks!

./vendor/bin/phpunit -v -c ./core/phpunit.xml ./modules/contrib/commerce/modules/cart/tests/src/Kernel/CartOrderPlacedTest.php 
PHPUnit 7.5.20 by Sebastian Bergmann and contributors.

Runtime:       PHP 7.2.24-0ubuntu0.18.04.3 with Xdebug 2.6.0
Configuration: /home/czigor/public_html/drupal8/core/phpunit.xml

Testing Drupal\Tests\commerce_cart\Kernel\CartOrderPlacedTest
.                                                                   1 / 1 (100%)

Time: 16.81 seconds, Memory: 6.00 MB

OK (1 test, 16 assertions)

Remaining deprecation notices (1)

  1x: Theme functions are deprecated in drupal:8.0.0 and are removed from drupal:10.0.0. Use Twig templates instead of theme_inline_entity_form_entity_table(). See https://www.drupal.org/node/1831138
    1x in CartOrderPlacedTest::testCartOrderPlaced from Drupal\Tests\commerce_cart\Kernel

  • xjm committed 6cd25df on 9.0.x 
    Issue #3120954 by tim.plunkett, czigor: Add function name to the...

  • xjm committed f614f61 on 8.9.x 
    Issue #3120954 by tim.plunkett, czigor: Add function name to the...
xjm’s picture

xjm
she/her
Primary language English
commented

Great improvement, thanks! Committed to 9.0.x and 8.9.x.

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.