The permissions are not working

really makes sense. Thanks for reporting.

It happens because we have a Views with permission perm: 'administer site configuration'

https://git.drupalcode.org/project/modal_page/-/blob/8.x-2.x/config/opti...

We need to fix that to allow views with manage modals permissions.

Good patch @csakiistvan!! Very good! Thanks a lot!

But we need to create as well a hook_update to update this views in website that already have Modal Page installed.

Example: https://git.drupalcode.org/project/modal_page/-/blob/8.x-2.x/modal_page....

P.s. The code probably will be the same.

/**
 * Implements hook_update_N().
 */
function modal_page_update_8201() {

  if (empty(\Drupal::moduleHandler()->moduleExists('views'))) {
    return FALSE;
  }

  $config_views_path = drupal_get_path('module', 'modal_page') . '/config/optional/views.view.list_modal.yml';

  $data = Yaml::decode(file_get_contents($config_views_path));

  \Drupal::configFactory()->getEditable('views.view.list_modal')->setData($data)->save(TRUE);

  \Drupal::service('cache.render')->invalidateAll();
}

My recommendation is to create a function called update_modal_page_views () and the hook update call this function

I have updated the views configs and added hook_update_n(). Please verify.

Thanks a lot for your help @wil2091

The function update_modal_page_views(); was a good catch!

I'll test soon

Thanks

New patch re-rol

Permission works for a new user who is not an administrator.

Tested with new user with new role and really works well now

Committed to the dev branch. @csakiistvan Thanks for reporting this.