I installed the Modal page module, and after that I create a new modal and left empty the pages field, because I would like to show my modal on every pages.

The pages field help text: "Leave this field blank to show the Modal in all pages." So I left empty this field.

I submitted the modal form, and I noticed the "path needs to start with a slash." and other notice (see my screenshot).

CommentFileSizeAuthor
#4 pages_field_empty_not_working-3120650-4.patch967 byteswil2091
Screenshot 2020-03-18 at 20.38.04.png164.41 KBcsakiistvan

Comments

csakiistvan created an issue. See original summary.

csakiistvan’s picture

csakiistvan
Primary language Hungarian
Location Budapest, Hungary
commented

I tried to add a simple / character to the pages field, but the modal is not visible

renatog’s picture

renatog commented

Oh yeah. Makes sense.

We need to check it.

Thanks for reporting.

wil2091’s picture

wil2091 commented
StatusFileSize
new pages_field_empty_not_working-3120650-4.patch967 bytes

Added a patch for validation. Please verify.

wil2091’s picture

wil2091 commented
Status: Active » Needs review
renatog’s picture

renatog commented

Thats great man!

We'll test it

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented

This was fixed here https://www.drupal.org/commitlog/commit/91087/ddea2eb8930cbf7123903eb4ab...

in issue #3100182: Modal is not working on alias page

please test the dev version

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Category: Bug report » Support request
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs review » Fixed
wil2091’s picture

wil2091 commented

Awesome. I see those added in dev version. Thanks!

renatog’s picture

renatog commented
Parent issue: » #3120374: [Plan] Release 8.x-2.8

Added this issue to the plan for the next release.

Thank you all, guys

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented

I would should has create another issue to this problem!
Sorry!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

wil2091’s picture

wil2091 commented