Problem/Motivation

Follow-up to #3034897: Sort list of enabled styles in paragraphs_collection.settings alphabetically

Proposed resolution

Remove the custom code and use orderby sequence schema attribute to automatically sort enabled styles.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#5 3120599-5-3-interdiff.txt796 bytesmbovan
#5 3120599-5.patch2.53 KBmbovan
#3 3120599-3-2-interdiff.txt505 bytesmbovan
#3 3120599-3.patch1.75 KBmbovan
#2 3120599-2.patch1.75 KBmbovan

Comments

mbovan created an issue. See original summary.

mbovan’s picture

mbovan commented
Title: Automatically sort list of enabled styles in paragraphs_collection.settings » Automatically sort configuration sequence lists provided by the module
Status: Active » Needs review
StatusFileSize
new 3120599-2.patch1.75 KB

A patch that fixes Paragraphs Collection sequence schema lists.

mbovan’s picture

mbovan commented
StatusFileSize
new 3120599-3.patch1.75 KB
new 3120599-3-2-interdiff.txt505 bytes

Changed ordering by value for available_grid_layouts, since Drupal\paragraphs_collection\Plugin\paragraphs\Behavior\ParagraphsGridLayoutPlugin::submitConfigurationForm() does not explicitly set keys.

Status: Needs review » Needs work

The last submitted patch, 3: 3120599-3.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

mbovan’s picture

mbovan commented
Status: Needs work » Needs review
StatusFileSize
new 3120599-5.patch2.53 KB
new 3120599-5-3-interdiff.txt796 bytes

By looking at how we are saving available_grid_layouts I think we should update the tests instead.

  • Berdir committed 77bd42a on 8.x-1.x authored by mbovan 
    Issue #3120599 by mbovan: Automatically sort configuration sequence...
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Nice, committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.