Closed (duplicate)
Project:
Revisions Aggregate
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
18 Mar 2020 at 09:56 UTC
Updated:
17 Jun 2020 at 14:22 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
sahana _n commentedPlease review the patch.
Comment #3
meghasharma commentedI have run the drupal_check and rector on revisions module. It showing errors
please fix the errors
Use rector, drupal_check, upgrade status and upgrade_rector on module!
my_site_name_dir % vendor/bin/drupal-check -ad web/modules/contrib/revisions
Warning: Class 'PHPUnit\Framework\MockObject\Matcher\InvokedRecorder' not found in /Users/Documents/sample/my_site_name_dir/web/core/tests/bootstrap.php on line 197
3/3 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
------ --------------------------------------------------------------------------------------------
Line src/Controller/RevisionsController.php
------ --------------------------------------------------------------------------------------------
51 Unsafe usage of new static().
💡 Consider making the class or the constructor final.
66 PHPDoc tag @param references unknown parameter: $node
116 Call to an undefined method Drupal\Core\Entity\EntityInterface::getTranslationLanguages().
119 Call to an undefined method Drupal\Core\Entity\EntityInterface::getType().
125 Call to an undefined method Drupal\Core\Entity\EntityInterface::getRevisionId().
142 Call to an undefined method Drupal\Core\Entity\EntityInterface::getRevisionId().
206 Call to an undefined method Drupal\Core\Entity\EntityInterface::getRevisionId().
236 Variable $header might not be defined.
------ --------------------------------------------------------------------------------------------
[ERROR] Found 8 errors
my_site_name_dir % vendor/bin/rector process web/modules/contrib/revisions --dry-run
Rector 0.8.x-dev@8896f0a
Config file: rector.yml
9/9 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
[ERROR] Could not process "web/modules/contrib/revisions/src/Controller/RevisionsController.php" file, due to:
"Analyze error: "ParseError (syntax error, unexpected 'error' (T_STRING)) thrown while autoloading class
Drupal\revisions\Controller\RevisionsController.". Include your files in "parameters > autoload_paths".
See https://github.com/rectorphp/rector#extra-autoloading".
Comment #4
shubhangi1995Comment #5
gaurav.kapoor commented