Parameter $entityQuery of method Drupal\serial\SerialSQLStorage::__construct() has typehint with deprecated class Drupal\Core\Entity\Query\QueryFactory. Deprecated in drupal:8.3.0 and is removed from drupal:9.0.0. Use \Drupal\Core\Entity\EntityStorageInterface::getQuery() or \Drupal\Core\Entity\EntityStorageInterface::getAggregateQuery() instead.

CommentFileSizeAuthor
#4 interdiff_3-4.txt768 bytescolorfield
#4 3120452-4.patch2.55 KBcolorfield
#3 deprecated-3120452-3.patch2.36 KBsergiu stici

Comments

mo_farhaz created an issue. See original summary.

mo_farhaz’s picture

mo_farhaz commented
Assigned: mo_farhaz » Unassigned
sergiu stici’s picture

sergiu stici commented
Status: Active » Needs review
StatusFileSize
new deprecated-3120452-3.patch2.36 KB

Here is the patch, please review.
We could use entityTypeManager since Drupal 8.6+ because of this service has ->getQuery() function, based on discussion on this post: https://www.drupal.org/node/2849874

colorfield’s picture

colorfield
Primary language French
Location Lausanne
commented
StatusFileSize
new 3120452-4.patch2.55 KB
new interdiff_3-4.txt768 bytes

Thank you for the patch, as we are using dependency injection for entity type manager, this is fine. Simplified the code a bit.

$storage = $this->entityTypeManager->getStorage($entityTypeId);
$query = $storage->getQuery();

  • colorfield committed 3eb4fbe on 8.x-1.x 
    Issue #3120452 by colorfield, Sergiu Stici: deprecated class...
colorfield’s picture

colorfield
Primary language French
Location Lausanne
commented

Committed so we can update #2977055: Use interface instead of class for SerialSQLStorage and close #3125326: Add core version requirement support for drupal 9. Feel free to re-open if necessary.

colorfield’s picture

colorfield
Primary language French
Location Lausanne
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.