The core_version_requirement key is needed in the module info file to declare compatibility with 9.x (and to allow it to be installed.

CommentFileSizeAuthor
#6 3120430-5.patch296 bytesbalsama
#4 3120430-4.patch294 bytesbalsama
#2 3120430-2.patch293 bytesbalsama

Comments

balsama created an issue. See original summary.

balsama’s picture

balsama
he/him
Primary language English
Location boston
commented
StatusFileSize
new 3120430-2.patch293 bytes

One-line patch attached.

anavarre’s picture

anavarre
Primary language French
Location 🇪🇺
commented 
+++ b/pendo.info.yml
@@ -2,4 +2,5 @@ name: 'Pendo'
 core: 8.x

If we don't need core compatibility before Drupal 8.7.7 we can drop this line entirely https://www.drupal.org/node/3119415

balsama’s picture

balsama
he/him
Primary language English
Location boston
commented
StatusFileSize
new 3120430-4.patch294 bytes

Good call. Update patch.

I also discussed this with @phenaproxima. He suggested making the constraint ^8.7,7 || ^9.0, but I think the >=8.7.7 is automatically handled by the absence of the core key. The CR also seems to imply that this is the "correct" way:
https://www.drupal.org/node/3070687

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Active » Needs work

I want testbot to confirm or deny this, but I believe that will not work. The problem is that '^8 || ^9' implies core versions before 8.7.7, which is when support for core_version_requirement was introduced. If I remember correctly, then, having a core version requirement of '^8 || ^9' without the 'core' key, will result in a parse exception.

balsama’s picture

balsama
he/him
Primary language English
Location boston
commented
Status: Needs work » Needs review
StatusFileSize
new 3120430-5.patch296 bytes

After much discussion, we agreed that this module just won't support core <8.8. Updated patch attached again.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Reviewed & tested by the community

Yup, makes sense to me. That seems like a good and sane version requirement.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 6: 3120430-5.patch, failed testing. View results

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Reviewed & tested by the community

This is a bogus failure, restoring RTBC.

  • phenaproxima committed 56a768b on 8.x-1.x 
    Issue #3120430 by balsama, phenaproxima, anavarre: Allow module to be...
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x-1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.