This patch will add a Media browser link into the Content menu and adds configuration to hide links and tabs to the Files and Media pages.
Routes are not removed, just the links and tabs are hidden visually which allows hiding items the users don't need to see anymore.

I think we should add it before full 1.0 release.

CommentFileSizeAuthor
#6 interdiff.txt9.45 KBytsurk
#6 3120400-hide_core_media_tabs_and_admin_toolbar_links-6.patch5.94 KBytsurk
#5 interdiff.txt8.74 KBytsurk
#5 3120400-hide_core_media_tabs_and_admin_toolbar_links-5.patch5.82 KBytsurk
#2 interdiff.txt5.13 KBytsurk
#2 3120400-hide_core_media_tabs_and_admin_toolbar_links-2.patch4.95 KBytsurk
hide-core-media-links-tabs.patch9.09 KBrang501

Comments

rang501 created an issue. See original summary.

ytsurk’s picture

ytsurk
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3120400-hide_core_media_tabs_and_admin_toolbar_links-2.patch4.95 KB
new interdiff.txt5.13 KB

Great work, once again @rang501!
This shall definitely go in asap.

The patch plays nicely, and the config options do work. It's good to exclude admin_toolbar menu links!

There is stuff inside this patch from the combined_upload, which I removed, also I changed the setting description text.

ytsurk’s picture

ytsurk
Location Switzerland
commented
Title: Add media browser link to menu, allow hiding core media links » Add media browser link to menu, allow hiding core media_library tabs and admin_toolbar_tools links
ytsurk’s picture

ytsurk
Location Switzerland
commented

Maybe the settings could be changed to

  • Hide Media tab
  • Hide File tab
  • Hide admin_toolbar_tools media links (only if module is enabled)
ytsurk’s picture

ytsurk
Location Switzerland
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 3120400-hide_core_media_tabs_and_admin_toolbar_links-5.patch5.82 KB
new interdiff.txt8.74 KB

So here we go ..

ytsurk’s picture

ytsurk
Location Switzerland
commented
StatusFileSize
new 3120400-hide_core_media_tabs_and_admin_toolbar_links-6.patch5.94 KB
new interdiff.txt9.45 KB

Missed the schema ..

rang501’s picture

rang501 commented
Status: Needs review » Reviewed & tested by the community

Seems fine. There was a small typo in the schema file, I'll fix it when committing these changes.

  • rang501 committed e099afe on 8.x-1.x 
    Issue #3120400 by ytsurk, rang501: Add media browser link to menu, allow...
rang501’s picture

rang501 commented
Status: Reviewed & tested by the community » Fixed
ytsurk’s picture

ytsurk
Location Switzerland
commented

I was thinking of disabling the menu entries and removing the hook (just to reduce hooks;)). What do you mean? Shall we make a followup?

rang501’s picture

rang501 commented

Yes, followup can be done if you think it would be better, but I think that could be a lower priority because it is more like a code polish :)

ytsurk’s picture

ytsurk
Location Switzerland
commented

Let's leave that .. they will be cached ;)

ytsurk’s picture

ytsurk
Location Switzerland
commented

Hmm - was thinking of removing some of this code again. Files and Media tab can be hidden via permissions ...

And then the admin_toolbar links should consequently also be hidden by role..

But also, this feature doesn't need to be used .. Maybe we should enhance the description of the setting.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.