Change the entity based options to field based options. There can be three options --- replace (the current behavior), add new multi value (the current option, for multi-value fields only), and append (a new option, for text fields only).

CommentFileSizeAuthor
#21 3120236-21.patch8.79 KBchr.fritsch
#21 interdiff-3120236-19-21.txt1.04 KBchr.fritsch
#19 3120236-19.patch8.28 KBchr.fritsch
#19 interdiff-3120236-18-19.txt7.17 KBchr.fritsch
#18 3120236-18.patch4.42 KBchr.fritsch
#16 vbe-3120236-16.patch7.52 KBdouggreen
#14 vbe-3120236-14.patch7.59 KBdouggreen
#13 vbe-3120236-13.patch7.52 KBdouggreen
#12 vbe-3120236-12.patch7.46 KBdouggreen
#11 vbe-3120236-11.patch7.46 KBdouggreen
#10 vbe-3120236-10.patch7.13 KBdouggreen
#9 vbe-3120236-9.patch5.71 KBdouggreen
#8 vbe-3120236-8.patch5.31 KBdouggreen
#7 vbe-3120236-7.patch5.69 KBdouggreen
#6 vbe-3120236-6.patch4.94 KBdouggreen
#2 vbe-3120236-2.patch2.22 KBdouggreen

Comments

douggreen created an issue. See original summary.

douggreen’s picture

douggreen commented
Status: Active » Needs review
StatusFileSize
new vbe-3120236-2.patch2.22 KB

patch attached

Status: Needs review » Needs work

The last submitted patch, 2: vbe-3120236-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

douggreen’s picture

douggreen commented
Issue summary: View changes
douggreen’s picture

douggreen commented
Title: Only show "Add values to multi-value fields" when there are multi-value fields » Make options per field
Issue summary: View changes
douggreen’s picture

douggreen commented
StatusFileSize
new vbe-3120236-6.patch4.94 KB

New patch for the updated ticket scope.

douggreen’s picture

douggreen commented
StatusFileSize
new vbe-3120236-7.patch5.69 KB

Updated patch removes the options fieldset.

douggreen’s picture

douggreen commented
StatusFileSize
new vbe-3120236-8.patch5.31 KB

New patch fixes the weight on the options radios.

douggreen’s picture

douggreen commented
StatusFileSize
new vbe-3120236-9.patch5.71 KB

New patch should fix test caused in my own patch creation (because I'm running 3 uncommitted patches on my project).

douggreen’s picture

douggreen commented
StatusFileSize
new vbe-3120236-10.patch7.13 KB

So sorry, new patch again tries to fix issues caused in my own patch creations (due to overlapping patches applied).

douggreen’s picture

douggreen commented
StatusFileSize
new vbe-3120236-11.patch7.46 KB

Sometimes it's just embarrassing ;( another patch ...

douggreen’s picture

douggreen commented
StatusFileSize
new vbe-3120236-12.patch7.46 KB
douggreen’s picture

douggreen commented
StatusFileSize
new vbe-3120236-13.patch7.52 KB

The last test was a real test failure (as opposed to all the test failures above due to bad retools). Here's an attempt to fix it.

douggreen’s picture

douggreen commented
StatusFileSize
new vbe-3120236-14.patch7.59 KB

I finally setup tests locally (should have done this earlier, sorry). Hopefully this will pass the bot.

douggreen’s picture

douggreen commented

It would be nice to add new tests for the new options.

douggreen’s picture

douggreen commented
StatusFileSize
new vbe-3120236-16.patch7.52 KB

Very weird, that's the wrong patch.

douggreen’s picture

douggreen commented
Status: Needs work » Needs review
chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
StatusFileSize
new 3120236-18.patch4.42 KB

Here is a re-roll that is based on the latest patch of #3112105: Create new revision

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
StatusFileSize
new interdiff-3120236-18-19.txt7.17 KB
new 3120236-19.patch8.28 KB

I fixed some small issues, changed the labels, and added a test.

Status: Needs review » Needs work

The last submitted patch, 19: 3120236-19.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-3120236-19-21.txt1.04 KB
new 3120236-21.patch8.79 KB

Fixing the tests

daniel.bosen’s picture

daniel.bosen
he/him
commented
Status: Needs review » Reviewed & tested by the community

Tha patch looks good and in works as advertised. Nice!

  • Graber committed 81e5f74 on 8.x-2.x authored by chr.fritsch 
    Issue #3120236 by douggreen, chr.fritsch: Make options per field
graber’s picture

graber commented
Status: Reviewed & tested by the community » Fixed

A nice improvement, thanks all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.