InfoParserDynamic will throw a different exception the 2nd time it is called with bad 'core_version_requirement' value

Problem/Motivation

#3119761: Replace multiple test methods in InfoParserUnitTest with 1 testInfoException and a dataprovider discovered in because that was converting all the test methods in \Drupal\Tests\Core\Extension\InfoParserUnitTest that thrown an exception into 1 method with a data provider.

\Drupal\Tests\Core\Extension\InfoParserUnitTest::testUnparsableCoreVersionRequirement() did not call the parser twice.

Therefore this call

try {
          $supports_pre_core_version_requirement_version = static::isConstraintSatisfiedByPreviousVersion($parsed_info['core_version_requirement'], static::FIRST_CORE_VERSION_REQUIREMENT_SUPPORTED_VERSION);
        }
        catch (\UnexpectedValueException $e) {
          throw new InfoParserException("The 'core_version_requirement' constraint ({$parsed_info['core_version_requirement']}) is not a valid value in $filename");
        }

in \Drupal\Core\Extension\InfoParserDynamic::parse() did not act as expect on the 2nd call.

isConstraintSatisfiedByPreviousVersion() has static var that caches the results for any $constraint and $version combination.
It assumes false so it sets
$evaluated_constraints[$constraint][$version] = FALSE;
Before it evaluates the combination.

The first time the exception is thrown after this is set. The second time

if (!isset($evaluated_constraints[$constraint][$version])) {
is true because it was set to FALSE before the exception is thrown.

So the method returns false.

This is bad but it is not as bad as it could be further down in the function we have

$core_version_constraint = isset($parsed_info['core_version_requirement']) ? $parsed_info['core_version_requirement'] : $parsed_info['core'];
      $parsed_info['core_incompatible'] = !Semver::satisfies(\Drupal::VERSION, $core_version_constraint);

If core version is invalid but we had the problem above this line still thrown exception because the original exception came from Semver::satisfies() evaluating the same value.

The only problem is that the reason we catch the error in the first place is to make the exception better my mentioning the filename of the info.yml file like all other parser errors, for example for a missing type key.

So the first time the parser is called with a invalid core_version_requirement value then get the exception we make with the filename and the 2nd time you get the exception straight from Semver::satisfies() without the filename

This make clear the importance of #3119761: Replace multiple test methods in InfoParserUnitTest with 1 testInfoException and a dataprovider so all our test methods in this class always call 2x and otherwise act the same.

Proposed resolution

In \Drupal\Core\Extension\InfoParserDynamic::isConstraintSatisfiedByPreviousVersion catch any exceptions and
unset($evaluated_constraints[$constraint][$version]);
Then rethrow the exception. That any exception regardless of type will not result in a cached false value.

Remaining tasks

Do it

User interface changes

API changes

Data model changes

Release notes snippet