On BanIpManager::__construct() the constructor is described as:

Construct the BanSubscriber.

The first word should be a verb using the third person singular, and the class name is wrong (BanSubscriber instead of BanIpManager).

Using a similar description used, for example, for BookManager::__construct(), the description should be the following one.

Constructs a BanIpManager object.

Comments

kiamlaluno created an issue. See original summary.

Deepthi kumari’s picture

Status: Active » Needs review
StatusFileSize
new537 bytes

Attached patch. Please review.

avpaderno’s picture

Status: Needs review » Reviewed & tested by the community
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed f4bda921fb to 9.0.x and fd453446d0 to 8.9.x and d9a6f40ec1 to 8.8.x. Thanks!

Backported to 8.8.x as docs fix.

  • alexpott committed f4bda92 on 9.0.x
    Issue #3119445 by kiamlaluno, Deepthi kumari: The documentation comment...

  • alexpott committed fd45344 on 8.9.x
    Issue #3119445 by kiamlaluno, Deepthi kumari: The documentation comment...

  • alexpott committed d9a6f40 on 8.8.x
    Issue #3119445 by kiamlaluno, Deepthi kumari: The documentation comment...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.