When running an update via drush, the log messages aren't that useful.

>  [notice] Checked translation for devel.
>  [notice] Checked translation for devel.
>  [notice] Checked translation for devel.
>  [notice] Checked translation for devel.
>  [notice] Checked translation for devel.
>  [notice] Checked translation for devel.
>  [notice] Checked translation for devel.
>  [notice] Checked translation for devel.
>  [notice] Checked translation for devel.
>  [notice] Checked translation for devel.
>  [notice] Checked translation for devel.
>  [notice] Checked translation for devel.
>  [notice] Checked translation for devel.
>  [notice] Checked translation for devel.
>  [notice] Checked translation for devel.
>  [notice] Checked translation for devel.
>  [notice] Checked translation for devel.
>  [notice] Checked translation for devel.
CommentFileSizeAuthor
#7 locale-better_messaging-3119278-7.patch2.63 KBnterbogt
#2 locale-better_messaging-3119278-2.patch2.63 KBnterbogt

Comments

nterbogt created an issue. See original summary.

nterbogt’s picture

nterbogt commented
StatusFileSize
new locale-better_messaging-3119278-2.patch2.63 KB
nterbogt’s picture

nterbogt commented
Status: Active » Needs review
nterbogt’s picture

nterbogt commented
Assigned: nterbogt » Unassigned
nterbogt’s picture

nterbogt commented
Version: 8.8.x-dev » 8.9.x-dev
hansfn’s picture

hansfn commented
Status: Needs review » Reviewed & tested by the community

Yes, this is very nice improvement - in particular for Drush users. Patch tested with 8.9.0-beta2 (and Drush 10.2.2).

I would prefer the messages to be "Checked %langcode translation for %project." instead of "Checked translation %langcode for %project." - and similar for the other message. If your try to read the same messages with language name instead of code, it's clearly better.

nterbogt’s picture

nterbogt commented
StatusFileSize
new locale-better_messaging-3119278-7.patch2.63 KB

I agree that "Checked %langcode translation ..." has better readability than "Checked translation %langcode ...".

Here is an updated patch.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 7: locale-better_messaging-3119278-7.patch, failed testing. View results

nterbogt’s picture

nterbogt commented
Status: Needs work » Reviewed & tested by the community

Tests failed due to server error.

quietone’s picture

quietone commented

Retested patch

  • catch committed a5be0a1 on 9.1.x 
    Issue #3119278 by nterbogt, hansfn: Better messaging for locale batches

  • catch committed 0ae813d on 9.0.x 
    Issue #3119278 by nterbogt, hansfn: Better messaging for locale batches...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 9.1.x/9.0.x/8.9.x, thanks!

  • catch committed 55c1b8a on 8.9.x 
    Issue #3119278 by nterbogt, hansfn: Better messaging for locale batches...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.