As part of working on #3095333: Extend filled database dump with new stable modules and content for them, I realized that rest is already enabled in the filled dump, and the custom fixtures we created are unnecessary. The test is a bit slower, but it's less code to maintain.

CommentFileSizeAuthor
#2 rest-update-test-3119027-2.patch2.97 KBberdir

Comments

Berdir created an issue. See original summary.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
StatusFileSize
new rest-update-test-3119027-2.patch2.97 KB
catch’s picture

catch
he/him
Primary language English
commented

Looks great. Queued up extra environments because it's been a week of regressions.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

nice clean-up!

  • catch committed ce1885d on 9.0.x 
    Issue #3119027 by Berdir, andypost: Use filled dump for...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

fixed this on commit:

h 
FILE: ...t/tests/src/Functional/Update/RestSettingsDeletionUpdateTest.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 19 | WARNING | [x] A comma should follow the last multiline array
    |         |     item. Found:
    |         |     '/../../../../../system/tests/fixtures/update/drupal-8.8.0.filled.standard.php.gz'
---------------------------

Committed ce1885d and pushed to 9.0.x. Thanks!

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

🥳🙏 Thanks, @Berdir! :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.