Closed (duplicate)
Project:
Drupal core
Version:
9.1.x-dev
Component:
documentation
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
10 Mar 2020 at 05:01 UTC
Updated:
21 Jun 2020 at 22:26 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
owenpm3 commentedComment #3
harpreet16 commentedComment #4
harpreet16 commentedThe patch works perfectly when applied by placing it in the project directory and using "patch -p1 < 3118831_2.patch" command.
See https://www.drupal.org/files/issues/2020-06-02/patch-p1-command.png.
But the patch does not apply with composer. Adding the following lines to end of "extras" in composer.json
and thereafter using the command "composer install" throws the error : https://www.drupal.org/files/issues/2020-06-02/patch-via-composer.png. Although something like https://www.linkedin.com/pulse/drupal-8-patch-workflow-files-docroot-tom... might be thought as a workaround for INSTALL.txt and other file changes within core/ may be used to generate the patch.
Note: Text within js files remain as it is. This patch affects only documentation and .module files
Comment #5
harpreet16 commentedComment #6
harpreet16 commentedComment #7
harpreet16 commentedTo make the patch working in a composer based setup, the patch needs to be modified as https://www.drupal.org/files/issues/2020-06-03/3118831_3.patch. Now add these lines to "extra" section of composer.json
Note that this patch does not include changes to INSTALL.txt present immediately within drupal project directory. To apply documentation changes to INSTALL.txt do the following:
Comment #8
atul4drupal commentedThanks for working on this standardization, updating for 9.x.
A few findings:
Still see use of this word at files that need attention
1) core/modules/help_topics/help_topics/user.security_account_settings.html.twig
2) core/modules/help_topics/help_topics/core.content_structure.html.twig
Comment #9
ankitsingh0188Comment #10
ankitsingh0188Updated the patch and
Standardize the use of "website" instead of "web site"in the remaining files.Comment #11
ankitsingh0188Updated interdiff.
Comment #13
hardik_patel_12 commentedComment #14
hardik_patel_12 commentedKindly review a new patch.
Comment #15
cburschkaThat interdiff file seems pretty broken... it looks as though two patch files were diffed instead?
Comment #16
cburschkaComment #17
atul4drupal commentedThanks all for working this .. patch #14 looks good.
Comment #19
longwaveConfirmed that no instances of "web site" remain after applying #14.
Comment #23
cburschkaThe testbot keeps re-testing one of the older patches. Not sure how to turn that off.
Comment #24
cburschkaMaybe just hiding the old patches will do it.
Comment #25
xjmThis issue appears to be a partial duplicate of #2256367: Consistently use "website" instead of "web site" in Drupal Core docs and UI text. Thanks!
Comment #26
xjm