Closed (fixed)
Project:
Views Aggregator Plus
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
10 Mar 2020 at 03:06 UTC
Updated:
3 Apr 2020 at 00:39 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
tr commentedOK, just the $defaultTheme thing which was changed in D8.8 (see https://www.drupal.org/node/3083055). We can make that change now, since it's compatible with older versions of Drupal 8.
Comment #3
tr commentedComment #4
tr commentedGetting closer ...
Comment #5
tr commentedThe version of PHPUnit used by D9 is more strict than the D8 version, so we need to modify the test cases accordingly. Specifically,
assertTrue()can only be used to test a boolean value - using it to test a numeric value will fail, as you can see from the test output.Comment #6
tr commentedThis is getting annoying. Same sort of issue - this time
assertFalse()can't be used on a string value in D9.Comment #7
tr commentedI missed one
assertFalse().Comment #8
tr commentedOK, so let me summarize the above. Bottom line: This module is fully D9 compatible with only a few minor changes to metadata and tests.
The patch in #7 does a few things:
assertTrue()andassertFalse()are only used to test boolean expressions.I propose to commit the patch in #7 then turn on automated testing for Drupal 9 and add a statement of Drupal 9 compatibility on the project page.
Comment #10
tr commentedCommitted.
Comment #11
jordik commentedWell done @TR! Thank you!
Comment #12
tr commentedAs a follow-up, the weekly testing against D9 that I turned on is now showing an error as of yesterday. Not sure why this didn't show up in the above tests, but it's there now. The error is:
The 'core_version_requirement' key must be present in modules/contrib/views_aggregator/views_aggregator_more_functions/views_aggregator_more_functions.info.ymland indeed this is a change that I should have included as part of task 1 in comment #8.
Here's the follow-up patch:
Comment #14
tr commentedCommitted.