The AddForm does not respect the keep selection mode.

The selection is always cleared, and the selection in keep mode will be only have the medias selected having the most used directory assigned.

CommentFileSizeAuthor
#6 3118807-respect_keep_selection_mode_in_addform-6.patch9.43 KBrang501
#2 3118807-respect_keep_selection_mode_in_addform-2.patch9.52 KBytsurk

Comments

ytsurk created an issue. See original summary.

ytsurk’s picture

ytsurk
Location Switzerland
commented
Assigned: ytsurk » Unassigned
Status: Active » Needs review
StatusFileSize
new 3118807-respect_keep_selection_mode_in_addform-2.patch9.52 KB

Here a patch addressing the issue.

ytsurk’s picture

ytsurk
Location Switzerland
commented
Issue summary: View changes
rang501’s picture

rang501 commented

I'm not sure what it should fix. The patch is applied but I don't see any differences, also no errors so I guess nothing breaks at least :)

ytsurk’s picture

ytsurk
Location Switzerland
commented

Thanks for the review! It's about selection in the entity browser.
If you have selected some items and press the Add button these will be cleared. This patch solves this issue on the media overview (/admin/content/browser) where we are in the keep selection mode. Also all newly added medias shall be selected when the AddForm is closed.

When we're adding medias in the field widget or via CKEditor button, where not in keep selection mode. And the selection shall be cleared, if new medias are added and the folder with the most new medias shall be selected, and only the medias in this folder - as the entity browser does not allow to have non-visible entities selected.

rang501’s picture

rang501 commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3118807-respect_keep_selection_mode_in_addform-6.patch9.43 KB

Yeah, the selection works as described after applying this patch.
The latest commit caused a conflict, so I made a new patch.

ytsurk’s picture

ytsurk
Location Switzerland
commented
Status: Reviewed & tested by the community » Fixed

  • ytsurk committed 08d0bda on 8.x-1.x 
    Issue #3118807 by ytsurk, rang501: Make the keep selection mode work...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.