Per https://www.drupal.org/project/commerce_currency_resolver/releases/8.x-1.50 the CurrencyHelper static helper is now a service and should be called by
\Drupal::service('commerce_currency_resolver.calculator')->priceConversion($input_price, $target_currency)

PrintfulShipping should remove Drupal\commerce_currency_resolver\Plugin\Commerce\CommerceCurrencyResolverAmountTrait and replace with the injected service.

Also, OrderItemsTrait needs to replace:

$totalPrice = CurrencyHelper::priceConversion($totalPrice, $pf_currency);

With:

$totalPrice = \Drupal::service('commerce_currency_resolver.calculator')->priceConversion($totalPrice, $pf_currency);

(or the injected service)

CommentFileSizeAuthor
#9 3118753-currencyhelper-is-now-a-service-9.patch4.31 KBscottsawyer
#8 3118753-currencyhelper-is-now-a-service-8.patch4.65 KBscottsawyer
#7 3118753-currencyhelper-is-now-a-service-7.patch4.21 KBscottsawyer
#4 3118753-currencyhelper-is-now-a-service-4.patch4.55 KBscottsawyer
#3 3118753-currencyhelper-is-now-a-service-3.patch3.44 KBscottsawyer
#2 3118753-currencyhelper-is-now-a-service-2.patch3.37 KBscottsawyer

Comments

scottsawyer created an issue. See original summary.

scottsawyer’s picture

scottsawyer
Primary language English
Location Atlanta
commented
Status: Active » Needs review
StatusFileSize
new 3118753-currencyhelper-is-now-a-service-2.patch3.37 KB

And a patch. Hopefully works with all the other patches.

scottsawyer’s picture

scottsawyer
Primary language English
Location Atlanta
commented
Related issues: +#3118530: Latest version of Commerce Shipping Breaking Changes
StatusFileSize
new 3118753-currencyhelper-is-now-a-service-3.patch3.44 KB

If you have already applied patch from #3118530: Latest version of Commerce Shipping Breaking Changes, then the previous patch will not apply.

scottsawyer’s picture

scottsawyer
Primary language English
Location Atlanta
commented
StatusFileSize
new 3118753-currencyhelper-is-now-a-service-4.patch4.55 KB

Sorry for the noise, there was more to do. This patch still depends on the one mentioned in #3

graber’s picture

graber commented
Status: Needs review » Needs work

Commerce Currency Resolver min version required in the .info.yml file

scottsawyer’s picture

scottsawyer
Primary language English
Location Atlanta
commented

Ok, I suppose we can just use the latest stable. I'll try to get an updated patch this week.

scottsawyer’s picture

scottsawyer
Primary language English
Location Atlanta
commented
Status: Needs work » Needs review
StatusFileSize
new 3118753-currencyhelper-is-now-a-service-7.patch4.21 KB

Added commerce_currency_resolver version requirement in commerce_printful.info.yml. Also needed a reroll per #3118530: Latest version of Commerce Shipping Breaking Changes. This patch also depends on the patch in #8

scottsawyer’s picture

scottsawyer
Primary language English
Location Atlanta
commented
StatusFileSize
new 3118753-currencyhelper-is-now-a-service-8.patch4.65 KB

Changes in #9 required changes to this patch.

scottsawyer’s picture

scottsawyer
Primary language English
Location Atlanta
commented
StatusFileSize
new 3118753-currencyhelper-is-now-a-service-9.patch4.31 KB

And this patch depends on #10

I also noticed an issue in my previous patches with $priceExchangerCalculator variable miss named. I had an ugly work around which this patch removes, so it's actually a cleaner patch.

cameron prince’s picture

cameron prince commented
Status: Needs review » Fixed

Confirmed and committed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.