Drupal\KernelTests\Core\Database\SelectTest fails on postgres 10

It looks like there isn't any explicit order by. Not sure why 10 behaves differently here when 9 or 12 do not, but order by is still important in those versions as well. Could it be pg_tgrm?

I'm not sure if we could programmatically add an order when the query is compiled.

The first query includes both George and Ringo, but those could be in any order. I think this should work to change the test. I don't have time to create a patch.

    $query_1 = $this->connection->select('test', 't')
      ->fields('t', ['name'])
      ->condition('age', [27, 28], 'IN')
      ->orderBy('name');

This test does not use ordering so could be simplified

#3 still seems to fail.

Tagging since this is blocking #2846994: Increase minimum version requirement for Postgres to 10 and require the pg_trgm extension.

pg 12.1 also has 10 a time field errors in queries

#7 that argument is deprecated. Maybe assertEqualsCanonicalizing will do, it is supported since PHPUnit8.

Queued a 8.9.x/Postgres 9.5 version to make sure this is safe for backport, as well as a few other flavors of database (Postgres and otherwise) given recent experience. We can expect the Postgres 12 one to fail with different issues, but this one shouldn't be in its list anymore.

#10 failed on 8.9.x / Postgres 9.1 with:

Drupal\KernelTests\Core\Database\SchemaTest
fail: [Other] Line 0 of sites/default/files/simpletest/phpunit-239.xml:
PHPunit Test failed to complete; Error: PHPUnit 7.5.20 by Sebastian Bergmann and contributors.

Testing Drupal\KernelTests\Core\Database\SchemaTest
..S...FF......                                                    14 / 14 (100%)

Time: 2.21 minutes, Memory: 4.00 MB

There were 2 failures:

1) Drupal\KernelTests\Core\Database\SchemaTest::testSchemaChangePrimaryKey with data set "composite_primary_key" (array('test_field', 'other_test_field'), array('test_field_renamed', 'other_test_field'))
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
-    0 => 'test_field_renamed'
-    1 => 'other_test_field'
+    0 => 'other_test_field'
+    1 => 'test_field_renamed'
 )

/var/www/html/core/tests/Drupal/KernelTests/Core/Database/SchemaTest.php:858

2) Drupal\KernelTests\Core\Database\SchemaTest::testSchemaChangePrimaryKey with data set "composite_primary_key_different_order" (array('other_test_field', 'test_field'), array('other_test_field', 'test_field_renamed'))
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
-    0 => 'other_test_field'
-    1 => 'test_field_renamed'
+    0 => 'test_field_renamed'
+    1 => 'other_test_field'
 )

/var/www/html/core/tests/Drupal/KernelTests/Core/Database/SchemaTest.php:858

FAILURES!
Tests: 14, Assertions: 1023, Failures: 2, Skipped: 1.
History

...but that's a fail I see in HEAD sometimes, so requeuing that environment

RE: #13 Yep, #2982755: Random failure in SchemaTest::testSchemaChangePrimaryKey with order of composite primary key.

It sounds like deja vu with assert equals vs identical before

Meanwhile, the retest passed. I think this fix is ready to go.

Meanwhile, I also posted #3118591: Datetime-related test failures on PostgreSQL 12.

Hm, according to #8, the assertEqualsCanonicalizing() method in the fix was introduced in PHPUnit 8. Drupal 9 was updated to require at least PHPUnit 8 in https://www.drupal.org/node/3113653 but Drupal 8.9 still has "phpunit/phpunit": "^6.5 || ^7", in https://git.drupalcode.org/project/drupal/-/blob/8.9.x/composer.json (I was looking to see if we maybe allow PHPUnit 8 with newer PHP versions in Drupal 8.9 as well, but did not find evidence).

Given all of that and that https://phpunit.readthedocs.io/en/7.0/search.html?q=assertEqualsCanonica... comes back empty (assertEqualsCanonicalizing() not mentioned in PHPUnit 7 docs), I am a bit puzzled how can this pass on Drupal 8.9.

Upon further URL hackery I found that it still does not appear in https://phpunit.readthedocs.io/en/7.4/assertions.html#assertequalscanoni... but it starts appearing in https://phpunit.readthedocs.io/en/7.5/assertions.html#assertequalscanoni... so this fix would require us to move to at least PHPUnit 7.5 as well.

That's a good approach as well.

Added an SQLite test to be safe, but RTBC assuming they all pass.

For reviewers: the 10 Postgres 12 failures are expected and will be addressed in #3118591: Datetime-related test failures on PostgreSQL 12 The minimum requirement for this issue is that the test pass on the other databases tested above.

Superb, thanks for this version.