Problem/Motivation

We worked around conflict between dependency versions on Drupal and postcss-header library by not loading postcss-header using the index file. This can be removed now that postcss-header has released a version that supports Babel 7.

Proposed resolution

Update to the latest version of postcss-header and remove the workaround.

Remaining tasks

User interface changes

CommentFileSizeAuthor
#2 3118079-2.patch26.04 KBlauriii

Comments

lauriii created an issue. See original summary.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Active » Needs review
StatusFileSize
new 3118079-2.patch26.04 KB
bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Needs review » Reviewed & tested by the community

I recall when the workaround was added in #2550717: [JS] Replace jQuery.cookie with JS-cookie and provide a BC layer, and the problem the workaround was added to address.

Locally, I manually confirmed the postcss-header update is no longer needed. It compiles without error, and does not introduce anything new/unexepcted.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

I can confirm that yarn build works just fine.

  • alexpott committed 335f53e on 9.0.x 
    Issue #3118079 by lauriii, bnjmnm: Remove postcss-header workaround
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

Committed 335f53e and pushed to 9.0.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.