Closed (fixed)
Project:
Olivero
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
5 Mar 2020 at 16:44 UTC
Updated:
18 Apr 2020 at 17:24 UTC
Jump to comment: Most recent, Most recent file

| Comment | File | Size | Author |
|---|---|---|---|
| #24 | Blog listing (Mobile) title and image alignment.png | 690.18 KB | sreenivas bttv |
| #24 | Blog listing (Desktop) Tags issues.png | 251.92 KB | sreenivas bttv |
| #23 | 3118071-teaser-23.patch | 13.8 KB | mherchel |
| #22 | 3118071-22-teaser-interdiff.patch | 10.09 KB | mherchel |
| #22 | 3118071-teaser-22.patch | 14.29 KB | mherchel |
Comments
Comment #2
proeungComment #3
proeungComment #4
Ujval Shah commented@proeung thank you for sharing the designs.
I am looking forward to starting an implementation of the same. Just to confirm, are we covering/supporting User Meta in the teasers ? Example: Author Picture, Name, Post Date.
Comment #5
kostyashupenkoArticle "Teaser" view display has much more fields than presented on design. How do you want to manage it?

"standard" installation of drupal has the following fields for Article "teaser" view display:
So on presented design there are no "Authored by", "Image", "Tags" and "Links" fields. Links field can contains lots of links, like "Read more", "Add new comment", "Login" (if anon user) and other.
Comment #6
proeung@kostyashupenko @Ujval Shah Thank you both for letting us know about the other fields that we haven't accounted for in the designs.
@jwitkowski79 What do you think about displaying some "Authored by", "Image", "Tags" and "Links" fields to the node teaser display mode?
Comment #7
mherchelAdding on to this, I'd love it if the teasers would show the image (if present). We'd have to accommodate a mixed use of images and no images.
Comment #8
jwitkowski79 commentedHey there!
I've updated the listing design to include
Image attached. I also updated this in the Figma file. Feedback welcome!

Comment #9
jwitkowski79 commentedComment #10
proeung@jwitkowski79 The revised comp looks great! Thanks for making this adjustment! I don't have any feedback for this design. All of the items that we've noted above have now been accounted for.
@kostyashupenko @mherchel I think this issue is ready for development.
Comment #11
mherchelComment #12
kostyashupenkoHello!
Thanks for your proposed design, it looks cool! Only one note - design for "Links" field is still missing (Re: #5). Would be great if you will add it!
Comment #13
mherchel@kostyashupenko - Just discussed this with @jwitkowski79 on Slack. We agree that we don't need the links field, and are going to omit it.
The "Read more" link is redundant and not needed, and the "Add new comment" link is also not needed.
Comment #14
mherchelWe should create a core issue to remove this from the teaser display within the standard profile.
But for the 8.x version, let's just omit it.
Comment #15
hansa11 commentedThe design updated in #8 looks great, everything mentioned in #5 (except the links which we are going to omit) has been covered, so if this is final, please let me know if I can pick this up for development.
Comment #16
hansa11 commentedComment #17
hansa11 commentedIn the mobile design, I noticed that we are not displaying the author field, are we planning to scrap off the author information in mobile design?

I think keeping the author's information won't make much difference to the design plus the User Experience will be the same for desktop and mobile users.
Also, the date format looks different for mobile, do we really need to render different date formats for desktop and mobile?
Comment #18
mherchel@jwitkowski79 has been working on them at https://www.figma.com/proto/r8uq72Q9weTMVsNUFZKEYH/D9-Theme-Master?node-.... I thought they were in the primary public Figma, but they're not yet there.
@hansa11: @proeung and I are sprinting on Olivero this weekend, and this is one of our targeted issues to knock out. Do you have a patch yet? If so, we can build on top of it. If not, we'll probably we putting this together today or tomorrow:
Comment #19
hansa11 commented@mherchel, yes I do have a patch, a few things are remaining if this needs to be completed on priority I'll try to wrap it up quickly and add the patch here in some time.
Thanks!
Comment #20
hansa11 commentedI am uploading the patch for article node teaser, please review and let me know
Thanks!
Comment #21
hansa11 commentedComment #22
mherchelThanks for doing the heavy lifting on this @hansa11! I made a few changes, and will get this committed shortly!
Comment #23
mherchelI had some debug code in the last commit. This one is better :)
Comment #24
sreenivas bttv commented@hansa11,
Nice work towards theming the article listing. While reviewing I found couple of theming issues.
Desktop:
Mobile:
Comment #25
sreenivas bttv commentedComment #26
sreenivas bttv commented@mherchel,
Sorry, I have seen your patch (#22, #23) little late after updated my comment (#24).
#23 patch working great and fixing teaser links issue.
Comment #27
sreenivas bttv commentedComment #28
hansa11 commented@mherchel and @Sreenivas Bttv: Thank you very much for your time to review my patch :)
@Sreenivas Bttv: The default theming for tags is covered in https://www.drupal.org/project/olivero/issues/3118088. So, I have made only the teaser specific changes for tags. For the links, as per #14, we are going to get it removed from the core for teasers, also Mike has made the required changes to the patch and omitted it from the twig itself for now.
Comment #29
mherchel@Sreenivas Bttv - The "tags" label would need to be changed in Drupal core's standard profile. We can create a followup issue if necessary -- but honestly, I think "tags" is okay.
I left the link styles within the tags the default, so they are more accessible.
I also opened #3124988: Better focus styles on title within node-teaser to implement a focus style on the teaser title.
Comment #31
Yuri commentedSorry to reply here - don't know where to post elsewhere - I see that the design of the article teaser reduces the article image to a small round thumbnail. Are you sure that this is supposed to be the article image, instead of the author profile image?
To me it makes no sense that the article image is crammed into a small thumbnail, no clear benefit, and looks like a mistake instead of being intentional. Cant we allow the article image to be above the teaser text?