Problem/Motivation

- We have a design for the Pager/Pagination component and now it's time to implement this feature in the Olivero Drupal theme.
- Here's the link to the design - https://www.figma.com/file/r8uq72Q9weTMVsNUFZKEYH/D9-Theme-Master?node-i...

Proposed resolution

- Theme/style core's Pager/Pagination component to match with the design for desktop and mobile breakpoints.
- Implement styling for the different pager blocks such as "Full" and "Mini" pagers.

Olivero Pager/Pagination component

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments

proeung created an issue. See original summary.

proeung’s picture

Issue summary: View changes
kostyashupenko’s picture

Assigned: Unassigned » kostyashupenko
kostyashupenko’s picture

Assigned: kostyashupenko » Unassigned
Status: Active » Needs review
StatusFileSize
new15.14 KB

Added templates for full/mini pagers, added styles.

kostyashupenko’s picture

Few things i noticed:
1. No ellipsis expected ? Currently it's removed.
2. We need focus/active design. Currently hover styles = focus styles, and for active there is

background-color: var(--color--gray-95); /* #F7F9FA Gray light 2 */

3. Need design for 320px screen resolution.

kostyashupenko’s picture

proeung’s picture

@kostyashupenko Thank you for submitting a patch for this issue. We'll take a look and provide feedback.

proeung’s picture

Status: Needs review » Needs work

@kostyashupenko Looks great! Thanks for submitting a patch for this issue. Please see my feedback below.

+++ b/olivero.info.yml
@@ -33,3 +33,8 @@ regions:
+        css/components/pager.css: css/dist/components/pager.css

Let's move the pager.css to our "global-styling" library instead of having it here. Also, I just wanted to note that we've removed `classy` as the base theme for Olivero. This work is part of the effort to remove Classy dependency on the core themes. #3050389: [META] Remove dependency to Classy from core themes

--------

Please see below for my response to the items that you've noticed.

1. No ellipsis expected? Currently, it's removed.

I believe this is intentional, however, let me confirm with the designers.

2. We need focus/active design. Currently hover styles = focus styles, and for active there is

I think what you have implemented will work fine for these hover states.

3. Need design for 320px screen resolution.

Yes, we need to figure out what the pager will look like on narrow screens, especially in a scenario where there are more than 3 pages as shown in your screenshot above.

Regardless, I think we're close to getting this patch merged into the development branch. We can follow up on additional styling for this component in another ticket. Thanks again for picking up this issue!

kostyashupenko’s picture

Status: Needs work » Needs review
StatusFileSize
new14.97 KB
new2.09 KB
proeung’s picture

Status: Needs review » Reviewed & tested by the community

@kostyashupenko The latest patch looks great! There were a couple of merge conflicts, but those issues are fixed and merged into the dev branch. Thanks again for picking this issue up!

proeung’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.