Closed (fixed)
Project:
Olivero
Component:
User interface
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
5 Mar 2020 at 16:22 UTC
Updated:
17 Apr 2020 at 15:24 UTC
Jump to comment: Most recent, Most recent file

Comments
Comment #2
proeungComment #3
kostyashupenkoComment #4
kostyashupenkoAdded templates for full/mini pagers, added styles.
Comment #5
kostyashupenkoFew things i noticed:
1. No ellipsis expected ? Currently it's removed.
2. We need focus/active design. Currently hover styles = focus styles, and for active there is
3. Need design for 320px screen resolution.
Comment #6
kostyashupenkoSome screenshots attached
Comment #7
proeung@kostyashupenko Thank you for submitting a patch for this issue. We'll take a look and provide feedback.
Comment #8
proeung@kostyashupenko Looks great! Thanks for submitting a patch for this issue. Please see my feedback below.
Let's move the pager.css to our "global-styling" library instead of having it here. Also, I just wanted to note that we've removed `classy` as the base theme for Olivero. This work is part of the effort to remove Classy dependency on the core themes. #3050389: [META] Remove dependency to Classy from core themes
--------
Please see below for my response to the items that you've noticed.
I believe this is intentional, however, let me confirm with the designers.
I think what you have implemented will work fine for these hover states.
Yes, we need to figure out what the pager will look like on narrow screens, especially in a scenario where there are more than 3 pages as shown in your screenshot above.
Regardless, I think we're close to getting this patch merged into the development branch. We can follow up on additional styling for this component in another ticket. Thanks again for picking up this issue!
Comment #9
kostyashupenkoComment #10
proeung@kostyashupenko The latest patch looks great! There were a couple of merge conflicts, but those issues are fixed and merged into the dev branch. Thanks again for picking this issue up!
Comment #11
proeung