See the following Search API issue/comment: #3056940-4: The "media_type" entity type does not exist..
There, we see an uncaught exception propagated from this module – specifically, the FilesExtractor processor. This is apparently caused by updating Search API Solr to 3.x while still staying on the contrib Media module instead of switching to the Core alternative.
However, in the code, it’s apparent that there could potentially be uncaught exceptions in other cases, too. I think we should just wrap that code in try/catch.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 3117949-5--FilesExtractor_error_handling.patch | 2.92 KB | drunken monkey |
Comments
Comment #2
drunken monkeyPlease see the attached patch draft and tell me what you think!
(I’m not sure what kind of logging or code style you would prefer, that’s why it’s only a draft.)
Comment #3
izus commentedhi,
i'm ok with that. thanks :)
we can just $this->logger->log() the plugin id concerned by InvalidPluginDefinitionException or PluginNotFoundException exceptions
Thanks a lot
Comment #4
izus commentedComment #5
drunken monkeyAlright. Something like this?
Comment #7
izus commentedThis is now merged
thanks a lot