Closed (fixed)
Project:
Drupal core
Version:
9.0.x-dev
Component:
base system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
4 Mar 2020 at 23:26 UTC
Updated:
1 May 2020 at 08:47 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
longwaveComment #3
kristen polComment #4
kristen polSorry for the delay. I'm going to try to do this one now.
Comment #5
kristen polThanks for the patch.
1) Reviewed the 9.0 dev codebase for the use of:
for
Constraints. The only ones with'Length'set are:but only
TypedDataTest.phphasminset. The rest are usingmax.Looked for
allowEmptyStringin the code and it was only inDeprecationListenerTrait.php.2) Since this is for Symfony 5 and the deprecation message states:
then adding:
shouldn't be needed though it is good to have there since it helps document what's needed if it should be set to
TRUE.3) Patch applies cleanly:
4) Not sure there is anything that can be manually tested so marking RTBC.
Comment #7
longwaveRandom fail, back to RTBC
Comment #10
catchCommitted c609c06 and pushed to 9.1.x, cherry-picked to 9.0.x. Thanks!