I was using this modules code in one of my other modules and I wanted to override some of the config from settings.php This doesn't seem to work when you try it like this: https://git.drupalcode.org/project/high_contrast/blob/8.x-1.x/src/EventS...
For some reason the data from event is incorrect. Instead this works:
$config = \Drupal::config('high_contrast.settings');
In settings.php you have something like this:
$config['high_contrast.settings']['colors_background'] = '#000000';
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | high_contrast-allow-config-override-from-settings-php-3117727-13.patch | 2.67 KB | neograph734 |
Comments
Comment #2
neograph734That makes sense... The configuration that the event receives is the configuration that has been saved (as that triggered the event). So those are the non-overridden values.
Feel free to provide a patch or commit directly. Issue and cause are explainable.
Comment #3
hkirsman commentedAdding patch
Comment #4
hkirsman commentedComment #6
hkirsman commentedI think it failed because we are missing tests.
Comment #7
hkirsman commentedComment #8
neograph734Let's follow best practices and use dependency injection instead. It is already there for the file system.
Comment #9
neograph734I think this should have the same result.
Comment #11
neograph734We have a passing test now, so this should no longer fail.
Comment #13
neograph734Missed the use statement.
Comment #14
hkirsman commentedLooks good!
Also tested by adding
$config['high_contrast.settings']['colors_background'] = 'red';to settings.php and saving form. Change was applied.
Comment #15
hkirsman commentedComment #17
neograph734Thanks, committed :)