Problem/Motivation

Running composer update drupal/core* on 9.0.x leads to this diff:

diff --git a/composer.lock b/composer.lock
index b75e457532..959558421e 100644
--- a/composer.lock
+++ b/composer.lock
@@ -457,7 +457,7 @@
             "dist": {
                 "type": "path",
                 "url": "core",
-                "reference": "f8e50d64acdddb816b10f83ca307712bd2cd65e5"
+                "reference": "1135d82ca80e22e7f25b1bd9a8613cae5ae06372"
             },
             "require": {
                 "asm89/stack-cors": "^1.1",

This is adding noise every time a release milestone is tagged.

Proposed resolution

Fix it.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#8 3117558-8.patch1.47 KBalexpott
#8 4-8-interdiff.txt587 bytesalexpott
#4 3117558-3.patch1.45 KBalexpott
#4 3117558-3-test-only.patch1 KBalexpott
#2 composer_lock.patch460 bytesxjm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

xjm created an issue. See original summary.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Status: Active » Needs review
FileSize
composer_lock.patch460 bytes
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented

FWIW, I verified that 8.9.x and 8.8.x do not have the same problem.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
FileSize
3117558-3-test-only.patch1 KB
3117558-3.patch1.45 KB

We can add a test for this so it doesn't happen in the future. We have something similar for the composer lock hash of the root composer.json.

The last submitted patch, 4: 3117558-3-test-only.patch, failed testing. View results

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Needs review » Reviewed & tested by the community

Superb, thanks! Good catch.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented 
+++ b/core/tests/Drupal/Tests/ComposerIntegrationTest.php
@@ -21,6 +21,16 @@ public function testComposerLockHash() {
+        $core_lock_file_hash = $package['dist']['reference'];

Nit: we can probably break; here once we have found the package we want.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
FileSize
4-8-interdiff.txt587 bytes
3117558-8.patch1.47 KB

@longwave sure why not.

  • catch committed d5fc3d9 on 9.0.x 
    Issue #3117558 by alexpott, xjm, longwave: 9.0.x core's hash in composer...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed d5fc3d9 and pushed to 9.0.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.