As per v1.0 breaking changes released last week, we might need to update to v1+:

https://github.com/gridstack/gridstack.js/blob/develop/README.md#migrati...

CommentFileSizeAuthor
#8 3117444-breaking-changes-update-v1-8.patch27.48 KBgausarts
#7 3117444-breaking-changes-update-v1-6.patch105.8 KBgausarts
#4 3117444-breaking-changes-update-v1-4.patch216.72 KBgausarts
#2 3117444-breaking-changes-update-v1-2.patch216.34 KBgausarts

Comments

gausarts created an issue. See original summary.

gausarts’s picture

gausarts commented
Status: Active » Needs review
StatusFileSize
new 3117444-breaking-changes-update-v1-2.patch216.34 KB

A few notable changes in the patch:

  • Added a hook_update() to remove deprecated settings, and use the new ones.
  • Updated sample optionsets to be responsive by default to test out the new CSS Grid layout without hustles.
  • Updated width = column, height = maxRow, setGridWidth() = column().
  • Cleaned up README from old customized GridStack libraries references.
  • Removed old customized GridStack libraries included with this module.
  • Removed old deprecated Use customized GridStack library option since it will no longer be compatible with v1.1+.

It appears less chaotic with admin UI. Either I fixed my mistakes, or the library is more stable, it is just better now, hopefully.
With this change, this module will work better with GridStack library v1.1+, unless another breaking changes happen again.

Let's see if any issue.

gausarts’s picture

gausarts commented
Status: Needs review » Needs work

The nested grids as used by Bootstrap/Foundation are broken now. The nodes were moved into GridStack.engine and likely few more changes need updating. Multiple nested used to silently fail is also broken now.

gausarts’s picture

gausarts commented
Status: Needs work » Needs review
StatusFileSize
new 3117444-breaking-changes-update-v1-4.patch216.72 KB

Addresses the nested issues, and a few more things.

  • gausarts committed 000f3d5 on 8.x-2.x 
    - Issue #3117444 by gausarts: Breaking changes with v1.0.
- Added a...
gausarts’s picture

gausarts commented

Committed incrementally to spot issues easier.

Will recheck anytime if anything I missed with the new v1.1 API before marking this fixed.

gausarts’s picture

gausarts commented
StatusFileSize
new 3117444-breaking-changes-update-v1-6.patch105.8 KB

A few refinements.

  • Added a new CSS class gridstack--gs to avoid conflicts against gridstack--native in case they are present on the same page since both share the same gridstack--js class.
  • Added a new option Use native CSS Grid to formatters and Views style.
  • Added micro optimization to data attributes to reduce JS complexity.
  • Respected Ungridstack for both native CSS and library js layouts.
  • Removed global native CSS Grid to use formatters or Views style to avoid conflicts with Outlayer, and also make it possible to stay side by side with old js-driven layout as needed.
  • Fixed for regressions with Outlayer at gridstack:8.x-2.3.
gausarts’s picture

gausarts commented
StatusFileSize
new 3117444-breaking-changes-update-v1-8.patch27.48 KB

Almost there:

  • Added a new is-gs-layout for re-usability with Outlayer sub-module.
  • Added a new CSS grid.static.css to have re-usable grid layout with minimum rules such as to support dynamic Isotope layouts along with native CSS Grid.
gausarts’s picture

gausarts commented
Status: Needs review » Fixed

That will do for now, I guess.

The commit appears to not appear here, but it was already done here: https://www.drupal.org/node/2672858/commits

Any (side) issue or improvement may follow as usual. Thanks!

  • gausarts committed a56257d on 8.x-2.x 
    - Issue #3117444 by gausarts: Breaking changes with v1.0.
- Added a new...

  • gausarts committed 5bfa5e7 on 8.x-2.x 
    Issue #3117444 by gausarts: Breaking changes with v1.0

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.