Update dependencies for Drupal 9 [#3117342]

Problem/Motivation

We did this not long ago in #3113985: Update dependencies for Drupal 9 but there have been a few updates since, we should upgrade all our dependencies before beta 1.

Proposed resolution

Run composer update --with-dependencies and commit.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

The following PHP dependencies have been updated since 9.0.0-beta1:

Symfony components have been updated from 4.4.4 to 4.4.5.
Composer has been updated from 1.9.3 to 1.10.0, and composer/installers is no longer pinned in drupal/core-recommended. comopser/installers may now be upgraded whenever a new version is available and a Composer-managed site runs composer update.
Several development dependencies including behat/mink-browserkit-driver, composer/xdebug-handler, phpdocumentor/reflection-docblock, phpdocumentor/type-resolver, and phpspec/prophecy have been updated to the latest compatible minor or patch versions.

Comment	File	Size	Author
#16	interdiff.3117342.12-16.txt	3.55 KB	longwave
#16	3117342-16.patch	42.89 KB	longwave
#12	3117342-12.patch	43.05 KB	longwave
#10	3117342-10-do-not-commit.patch	42.67 KB	longwave
#6	3117342-6.patch	35.95 KB	alexpott
#6	2-6-interdiff.txt	704 bytes	alexpott
#2	3117342.patch	35.26 KB	longwave

Comments

Comment #1

3 March 2020 at 10:04

longwave created an issue. See original summary.

Comment #2

longwave

he/him

English

commented 3 March 2020 at 10:05

Status:

Active

» Needs review

Status	File	Size
new	3117342.patch	35.26 KB

$ composer-lock-diff --no-links
+------------------------------+--------+--------+
| Production Changes           | From   | To     |
+------------------------------+--------+--------+
| symfony/console              | v4.4.4 | v4.4.5 |
| symfony/debug                | v4.4.4 | v4.4.5 |
| symfony/dependency-injection | v4.4.4 | v4.4.5 |
| symfony/error-handler        | v4.4.4 | v4.4.5 |
| symfony/event-dispatcher     | v4.4.4 | v4.4.5 |
| symfony/http-foundation      | v4.4.4 | v4.4.5 |
| symfony/http-kernel          | v4.4.4 | v4.4.5 |
| symfony/mime                 | v5.0.4 | v5.0.5 |
| symfony/process              | v4.4.4 | v4.4.5 |
| symfony/routing              | v4.4.4 | v4.4.5 |
| symfony/serializer           | v4.4.4 | v4.4.5 |
| symfony/translation          | v4.4.4 | v4.4.5 |
| symfony/validator            | v4.4.4 | v4.4.5 |
| symfony/var-dumper           | v5.0.4 | v5.0.5 |
| symfony/yaml                 | v4.4.4 | v4.4.5 |
+------------------------------+--------+--------+

+-----------------------------------+--------+--------+
| Dev Changes                       | From   | To     |
+-----------------------------------+--------+--------+
| composer/xdebug-handler           | 1.4.0  | 1.4.1  |
| phpdocumentor/reflection-docblock | 5.0.0  | 5.1.0  |
| phpdocumentor/type-resolver       | 1.0.1  | 1.1.0  |
| symfony/browser-kit               | v4.4.4 | v4.4.5 |
| symfony/css-selector              | v4.4.4 | v4.4.5 |
| symfony/dom-crawler               | v4.4.4 | v4.4.5 |
| symfony/filesystem                | v4.4.4 | v4.4.5 |
| symfony/finder                    | v4.4.4 | v4.4.5 |
| symfony/lock                      | v4.4.4 | v4.4.5 |
| symfony/phpunit-bridge            | v4.4.4 | v4.4.5 |
+-----------------------------------+--------+--------+

Comment #3

longwave

he/him

English

commented 3 March 2020 at 10:07

Parent issue:

» #3009213: [META] Update / reconsider PHP dependencies for Drupal 9

Comment #4

3 March 2020 at 11:03

Status:

Needs review

» Needs work

The last submitted patch, 2: 3117342.patch, failed testing. View results

Comment #5

longwave

he/him

English

commented 3 March 2020 at 11:12

DomCrawler related fails could be to do with https://github.com/symfony/symfony/pull/34059

Status	File	Size
new	2-6-interdiff.txt	704 bytes
new	3117342-6.patch	35.95 KB

Comment #7

3 March 2020 at 12:26

Status:

Needs review

» Needs work

The last submitted patch, 6: 3117342-6.patch, failed testing. View results

Comment #8

alexpott

he/they

English

🇪🇺🌍

commented 3 March 2020 at 12:42

I'm trying to convince Symfony to revert this change - see https://github.com/symfony/symfony/pull/34059 - sounds like a revert is going to happen.

Comment #9

alexpott

he/they

English

🇪🇺🌍

commented 3 March 2020 at 14:14

So the upstream revert occurred.

Comment #10

longwave

he/him

English

commented 10 March 2020 at 23:06

Status:

Needs work

» Needs review

Status	File	Size
new	3117342-10-do-not-commit.patch	42.67 KB

Let's try again with symfony/dom-crawler 4.4.x-dev and see what we need to fix while waiting for Symfony 4.4.6.

edit: oh, the revert was only done in the 3.4 branch so far, so this won't work anyway :(

$ composer-lock-diff --no-links
+------------------------------+--------+--------+
| Production Changes           | From   | To     |
+------------------------------+--------+--------+
| symfony/console              | v4.4.4 | v4.4.5 |
| symfony/debug                | v4.4.4 | v4.4.5 |
| symfony/dependency-injection | v4.4.4 | v4.4.5 |
| symfony/error-handler        | v4.4.4 | v4.4.5 |
| symfony/event-dispatcher     | v4.4.4 | v4.4.5 |
| symfony/http-foundation      | v4.4.4 | v4.4.5 |
| symfony/http-kernel          | v4.4.4 | v4.4.5 |
| symfony/mime                 | v5.0.4 | v5.0.5 |
| symfony/process              | v4.4.4 | v4.4.5 |
| symfony/routing              | v4.4.4 | v4.4.5 |
| symfony/serializer           | v4.4.4 | v4.4.5 |
| symfony/translation          | v4.4.4 | v4.4.5 |
| symfony/validator            | v4.4.4 | v4.4.5 |
| symfony/var-dumper           | v5.0.4 | v5.0.5 |
| symfony/yaml                 | v4.4.4 | v4.4.5 |
+------------------------------+--------+--------+

+-----------------------------------+---------+-----------+
| Dev Changes                       | From    | To        |
+-----------------------------------+---------+-----------+
| behat/mink                        | a534fe7 | ccef198   |
| composer/composer                 | 1.9.3   | 1.10.0    |
| composer/xdebug-handler           | 1.4.0   | 1.4.1     |
| phpdocumentor/reflection-docblock | 5.0.0   | 5.1.0     |
| phpdocumentor/type-resolver       | 1.0.1   | 1.1.0     |
| phpspec/prophecy                  | v1.10.2 | v1.10.3   |
| symfony/browser-kit               | v4.4.4  | v4.4.5    |
| symfony/css-selector              | v4.4.4  | v4.4.5    |
| symfony/dom-crawler               | v4.4.4  | 4.4.x-dev |
| symfony/filesystem                | v4.4.4  | v4.4.5    |
| symfony/finder                    | v4.4.4  | v4.4.5    |
| symfony/lock                      | v4.4.4  | v4.4.5    |
| symfony/phpunit-bridge            | v4.4.4  | v4.4.5    |
+-----------------------------------+---------+-----------+

Comment #11

11 March 2020 at 00:03

Status:

Needs review

» Needs work

The last submitted patch, 10: 3117342-10-do-not-commit.patch, failed testing. View results

Comment #12

longwave

he/him

English

commented 13 March 2020 at 13:08

Status:

Needs work

» Needs review

Status	File	Size
new	3117342-12.patch	43.05 KB

We can say that we explicitly don't want symfony/dom-crawler 4.4.5, but anything else is OK?

A deprecation message has also changed which is the cause of some other failures, fixed here.

$ composer-lock-diff --no-links
+------------------------------+--------+--------+
| Production Changes           | From   | To     |
+------------------------------+--------+--------+
| symfony/console              | v4.4.4 | v4.4.5 |
| symfony/debug                | v4.4.4 | v4.4.5 |
| symfony/dependency-injection | v4.4.4 | v4.4.5 |
| symfony/error-handler        | v4.4.4 | v4.4.5 |
| symfony/event-dispatcher     | v4.4.4 | v4.4.5 |
| symfony/http-foundation      | v4.4.4 | v4.4.5 |
| symfony/http-kernel          | v4.4.4 | v4.4.5 |
| symfony/mime                 | v5.0.4 | v5.0.5 |
| symfony/process              | v4.4.4 | v4.4.5 |
| symfony/routing              | v4.4.4 | v4.4.5 |
| symfony/serializer           | v4.4.4 | v4.4.5 |
| symfony/translation          | v4.4.4 | v4.4.5 |
| symfony/validator            | v4.4.4 | v4.4.5 |
| symfony/var-dumper           | v5.0.4 | v5.0.5 |
| symfony/yaml                 | v4.4.4 | v4.4.5 |
+------------------------------+--------+--------+

+-----------------------------------+---------+---------+
| Dev Changes                       | From    | To      |
+-----------------------------------+---------+---------+
| behat/mink-browserkit-driver      | 1.3.3   | v1.3.4  |
| composer/composer                 | 1.9.3   | 1.10.0  |
| composer/xdebug-handler           | 1.4.0   | 1.4.1   |
| phpdocumentor/reflection-docblock | 5.0.0   | 5.1.0   |
| phpdocumentor/type-resolver       | 1.0.1   | 1.1.0   |
| phpspec/prophecy                  | v1.10.2 | v1.10.3 |
| symfony/browser-kit               | v4.4.4  | v4.4.5  |
| symfony/css-selector              | v4.4.4  | v4.4.5  |
| symfony/filesystem                | v4.4.4  | v4.4.5  |
| symfony/finder                    | v4.4.4  | v4.4.5  |
| symfony/lock                      | v4.4.4  | v4.4.5  |
| symfony/phpunit-bridge            | v4.4.4  | v4.4.5  |
+-----------------------------------+---------+---------+

Comment #13

berdir

German

Switzerland

commented 13 March 2020 at 13:19

+++ b/core/tests/Drupal/Tests/Listeners/DeprecationListenerTrait.php
@@ -152,7 +152,7 @@ public static function getSkippedDeprecations() {
       'The signature of the "Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher::dispatch()" method should be updated to "dispatch($event, string $eventName = null)", not doing so is deprecated since Symfony 4.3.',
       'Calling the "Symfony\Component\EventDispatcher\EventDispatcherInterface::dispatch()" method with the event name as the first argument is deprecated since Symfony 4.3, pass it as the second argument and provide the event object as the first argument instead.',
-      'The "Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher::dispatch()" method will require a new "string|null $eventName" argument in the next major version of its parent class "Symfony\Contracts\EventDispatcher\EventDispatcherInterface", not defining it is deprecated.',
+      'The "Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher::dispatch()" method will require a new "string|null $eventName" argument in the next major version of its interface "Symfony\Contracts\EventDispatcher\EventDispatcherInterface", not defining it is deprecated.',
       'Passing a command as string when creating a "Symfony\Component\Process\Process" instance is deprecated since Symfony 4.2, pass it as an array of its arguments instead, or use the "Process::fromShellCommandline()" constructor if you need features provided by the shell.',
       'Passing arguments to "Symfony\Component\HttpFoundation\Request::isMethodSafe()" has been deprecated since Symfony 4.4; use "Symfony\Component\HttpFoundation\Request::isMethodCacheable()" to check if the method is cacheable instead.',
       'The "Symfony\Component\Process\Process::inheritEnvironmentVariables()" method is deprecated since Symfony 4.4, env variables are always inherited.',

should we keep both versions instead of changing it, so that it doesn't start to show up in case someone still has the old version? min-version testing and stuff like that.

Comment #15

catch

he/him

English

commented 13 March 2020 at 16:09

Status:

Needs review

» Needs work

For #13 we could also raise the minimums above to ones with the old messages since we haven't released yet, there's an open issue discussing keeping out minimum versions inline with what's in composer.lock

Needs work for either option though I think.

Comment #16

longwave

he/him

English

commented 13 March 2020 at 16:24

Status:

Needs work

» Needs review

Status	File	Size
new	3117342-16.patch	42.89 KB
new	interdiff.3117342.12-16.txt	3.55 KB

Added both deprecation messages, as that seems simplest for now; we don't need to bump the minimum version just for this.

Also changed the constraint slightly as you don't need both comma and space for AND, just space is needed.

Comment #17

alexpott

he/they

English

🇪🇺🌍

commented 19 March 2020 at 09:19

Status:

Needs review

» Reviewed & tested by the community

This looks great. RTBCing because this patch no longer contains my work.

Comment #18

19 March 2020 at 11:16

catch committed 0d78f4c on 9.0.x

Issue #3117342 by longwave, alexpott: Update dependencies for Drupal 9

Comment #19

catch

he/him

English

commented 19 March 2020 at 11:16

Status:

Reviewed & tested by the community

» Fixed

Committed 0d78f4c and pushed to 9.0.x. Thanks!

Comment #20

xjm

she/her

English

commented 20 March 2020 at 13:47

Issue tags:

+9.0.0 release notes

Comment #21

3 April 2020 at 13:49

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Comment #22

pameeela commented 6 May 2020 at 23:15

Issue tags:

+Needs release note

Not sure how we summarise this in release notes - do we list all the changes, or link to a list somewhere else?

Comment #23

xjm

she/her

English

commented 15 May 2020 at 19:53

Status:

Closed (fixed)

» Needs work

The summary in #3122112: Update dependencies for Drupal 8.9 has an example (not the raw command output, but the listed "highlights").

Comment #24

xjm

she/her

English

commented 15 May 2020 at 20:02

Issue summary:	View changes
Status:	Needs work	» Fixed
Issue tags:	-Needs release note

Wrote a release note (and rolled in #3134648: [backport, needs scheduling] Don't pin the composer/installers version in drupal/core-recommended since it is best mentioned in context of the Composer update).

Comment #25

xjm

she/her

English

commented 15 May 2020 at 20:12

Issue summary:

View changes

Oops, this was already in beta2. I'll add this to the published release notes there.

Comment #26

29 May 2020 at 20:14

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.