Problem/Motivation

As we've now updated to Twig2 we can clean up a few deprecations that we added in for SF4 compatbility.

Proposed resolution

Clean up the code and remove unneeded skipped deprecations

Remaining tasks

User interface changes

None

API changes

None - we're no longer implementing an empty interface and we removing methods we no longer need to implement because they are not on the interface anymore.

Data model changes

None

Release notes snippet

None

CommentFileSizeAuthor
#3 3117250-3.patch3.37 KBalexpott
#3 2-3-interdiff.txt1.04 KBalexpott
#2 3117250-2.patch2.33 KBalexpott

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
StatusFileSize
new 3117250-2.patch2.33 KB

Let's see if this works..

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
StatusFileSize
new 2-3-interdiff.txt1.04 KB
new 3117250-3.patch3.37 KB

One more thing we can do...

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Title: Update StringLoader for Twig2 » Update StringLoader and TestLoader for Twig2
Issue summary: View changes
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

Looks good, no more uses of the deprecated interfaces remain.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: 3117250-3.patch, failed testing. View results

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Reviewed & tested by the community

1) Drupal\BuildTests\Framework\Tests\BuildTestTest::testPortMany
RuntimeException: Unable to start the web server.

Retesting

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Title: Update StringLoader and TestLoader for Twig2 » Update StringLoader and TestLoader for Twig 3 compatibility

So this is for Twig 3 forward compatibility, let's title it like that.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: 3117250-3.patch, failed testing. View results

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Reviewed & tested by the community

1) Drupal\Tests\media_library\FunctionalJavascript\WidgetUploadTest::testWidgetUploadAdvancedUi
"image-1.png" not found
Failed asserting that a boolean is not empty.

  • catch committed 51e3dc8 on 9.0.x 
    Issue #3117250 by alexpott, longwave: Update StringLoader and TestLoader...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed 51e3dc8 and pushed to 9.0.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.