Closed (fixed)
Project:
Particle Responsive
Version:
8.x-4.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
2 Mar 2020 at 10:31 UTC
Updated:
25 Mar 2020 at 06:19 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
rudranil29 commentedpatch added here.
Comment #3
rudranil29 commentedComment #4
swatichouhan012 commentedHii @joy29 Thank you for your contribution in particle responsive theme. i applied patch and its showing undefined $this variable.
here you used $this but you did not use messenger service here, I am moving this in Needs work, feel free to apply patch here.
------------------------------------------------------------------------------------
23 | WARNING | Variable $this is undefined.
29 | WARNING | Variable $this is undefined.
31 | WARNING | Variable $this is undefined.
35 | WARNING | Variable $this is undefined.
41 | WARNING | Variable $this is undefined.
43 | WARNING | Variable $this is undefined.
50 | WARNING | Variable $this is undefined.
56 | WARNING | Variable $this is undefined.
61 | WARNING | Variable $this is undefined.
66 | WARNING | Variable $this is undefined.
71 | WARNING | Variable $this is undefined.
88 | WARNING | Variable $this is undefined.
94 | WARNING | Variable $this is undefined.
96 | WARNING | Variable $this is undefined.
100 | WARNING | Variable $this is undefined.
105 | WARNING | Variable $this is undefined.
110 | WARNING | Variable $this is undefined.
115 | WARNING | Variable $this is undefined.
120 | WARNING | Variable $this is undefined.
128 | WARNING | Variable $this is undefined.
134 | WARNING | Variable $this is undefined.
136 | WARNING | Variable $this is undefined.
141 | WARNING | Variable $this is undefined.
146 | WARNING | Variable $this is undefined.
148 | WARNING | Variable $this is undefined.
Comment #5
karishmaamin commentedComment #6
karishmaamin commentedPlease review the code.
Comment #7
Anonymous (not verified) commentedHello,
you made a small mistake. I uploaded your patch with interdiff.
Thanks for your work and kind regards, Denis
Comment #8
swatichouhan012 commentedThanks @DenisCi @karishmaamin @joy29 for your contribution. I commited changes in 8.x-4.x-dev , Will merge this in next release.