1. Replace array() with []
2. $this missing.

CommentFileSizeAuthor
#7 interdiff_6-7.txt363 bytesAnonymous (not verified)
#7 3117065-7.patch8.81 KBAnonymous (not verified)
#6 updated-3117065-6.patch8.81 KBkarishmaamin
#2 particle_responsive-3117065-2.patch9.17 KBrudranil29

Comments

joy29 created an issue. See original summary.

rudranil29’s picture

StatusFileSize
new9.17 KB

patch added here.

rudranil29’s picture

Assigned: rudranil29 » Unassigned
Status: Active » Needs review
swatichouhan012’s picture

Status: Needs review » Needs work
Issue tags: +VbContribution2020

Hii @joy29 Thank you for your contribution in particle responsive theme. i applied patch and its showing undefined $this variable.
here you used $this but you did not use messenger service here, I am moving this in Needs work, feel free to apply patch here.

------------------------------------------------------------------------------------
23 | WARNING | Variable $this is undefined.
29 | WARNING | Variable $this is undefined.
31 | WARNING | Variable $this is undefined.
35 | WARNING | Variable $this is undefined.
41 | WARNING | Variable $this is undefined.
43 | WARNING | Variable $this is undefined.
50 | WARNING | Variable $this is undefined.
56 | WARNING | Variable $this is undefined.
61 | WARNING | Variable $this is undefined.
66 | WARNING | Variable $this is undefined.
71 | WARNING | Variable $this is undefined.
88 | WARNING | Variable $this is undefined.
94 | WARNING | Variable $this is undefined.
96 | WARNING | Variable $this is undefined.
100 | WARNING | Variable $this is undefined.
105 | WARNING | Variable $this is undefined.
110 | WARNING | Variable $this is undefined.
115 | WARNING | Variable $this is undefined.
120 | WARNING | Variable $this is undefined.
128 | WARNING | Variable $this is undefined.
134 | WARNING | Variable $this is undefined.
136 | WARNING | Variable $this is undefined.
141 | WARNING | Variable $this is undefined.
146 | WARNING | Variable $this is undefined.
148 | WARNING | Variable $this is undefined.

karishmaamin’s picture

Assigned: Unassigned » karishmaamin
karishmaamin’s picture

Assigned: karishmaamin » Unassigned
Status: Needs work » Needs review
StatusFileSize
new8.81 KB

Please review the code.

Anonymous’s picture

StatusFileSize
new8.81 KB
new363 bytes

Hello,
you made a small mistake. I uploaded your patch with interdiff.
Thanks for your work and kind regards, Denis

swatichouhan012’s picture

Status: Needs review » Fixed

Thanks @DenisCi @karishmaamin @joy29 for your contribution. I commited changes in 8.x-4.x-dev , Will merge this in next release.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.