To me it appears kind of unnecessary to load the bootstrap library in bootstrap4_modal.libraries.yml since anyone using this module will implement bootstrap by its own theme.

So I would propose to remove it.

CommentFileSizeAuthor
#3 bootstrap4_modal-remove-boostrap-lib-3116201-3.patch3.47 MBdevkinetic
#2 bootstrap4_modal-remove-boostrap-lib-3116201-2.patch952 bytesdevkinetic

Comments

demonde created an issue. See original summary.

devkinetic’s picture

devkinetic commented
Status: Active » Needs review
StatusFileSize
new bootstrap4_modal-remove-boostrap-lib-3116201-2.patch952 bytes

Here is a patch based on 1.x-dev. It looks like it was already removed from composer, but it was still defined in the libraries.yml.

devkinetic’s picture

devkinetic commented
StatusFileSize
new bootstrap4_modal-remove-boostrap-lib-3116201-3.patch3.47 MB

This removes the lib itself and another reference in the ajax #attached.

devkinetic’s picture

devkinetic commented
vhin0210’s picture

vhin0210 commented
vhin0210’s picture

vhin0210 commented

Applied the patch on 1.x-dev and also added dependency on bootstrap_library module instead so the modal can be used with non bootstrap themes

  • vhin0210 committed 8415220 on 8.x-1.x 
    Issue #3116201 by demonde,devkinetic: Apply patch files and require...

vhin0210’s picture

vhin0210 commented

Removed the bootstrap_library dependency because it's causing css problems on admin theme.

devkinetic’s picture

devkinetic commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.