Problem/Motivation

In #3069696: Remove BC layers from the entity system we removed most deprecated code from the entity system, but we missed at least a couple of trigger_error() calls:

core/lib/Drupal/Core/Entity/EntityDefinitionUpdateManager.php: trigger_error('EntityDefinitionUpdateManagerInterface::applyUpdates() is deprecated in 8.7.0 and will be removed before Drupal 9.0.0. Use \Drupal\Core\Entity\EntityDefinitionUpdateManagerInterface::getChangeList() and execute each entity type and field storage update manually instead. See https://www.drupal.org/node/3034742.', E_USER_DEPRECATED);

core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php: @trigger_error('Passing a single revision ID to "\Drupal\Core\Entity\Sql\SqlContentEntityStorage::buildQuery()" is deprecated in Drupal 8.5.x and will be removed before Drupal 9.0.0. An array of revision IDs should be given instead. See https://www.drupal.org/node/2924915.', E_USER_DEPRECATED);

Proposed resolution

Remove the remaining deprecated code.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3116103.patch3.15 KBlongwave

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review
StatusFileSize
new 3116103.patch3.15 KB

Also found a reference to ::applyUpdates() in a comment that no longer applies.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Parent issue: » #2716163: [META] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules on the Drupal 9 branch
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Reviewed & tested by the community

Looks good.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 3c5abe4 and pushed to 9.0.x. Thanks!

  • alexpott committed 3c5abe4 on 9.0.x 
    Issue #3116103 by longwave: Remove remaining deprecated code from Entity...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.