Closed (duplicate)
Project:
Drupal core
Version:
8.9.x-dev
Component:
other
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
26 Feb 2020 at 07:12 UTC
Updated:
23 Apr 2020 at 19:38 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
swatichouhan012 commentedKindly review patch.
Comment #3
jungleI found following info.yml files having such an issue too. And I think it's ok to enlarge the scope to the whole codebase.
Comment #4
jungleComment #5
jungleComment #6
jungleComment #7
baroneThe patch failed to alter one of the files: core/modules/migrate_drupal_multilingual/migrate_drupal_multilingual.info.yml with the error message:
Contents of that .rej file are:
Comment #8
baroneFor all the other 4 files, i can confirm the patch worked as expected.
Comment #9
jungle@barone, Thanks for reviewing! Patch rerolled.
Comment #10
junglePatches for 8.8.x, and 9.0.x
Comment #11
quietone commentedThanks for the work on tidying this up.
However, there is no evidence here that all the info.yml files are fixed. So I tried this `grep -r -A20 --include="*.info.yml" 'dependencies:' | grep ' - ' | grep -v 'drupal:' ` which results in
It may not be the most elegant of commands but it does find that there are more info files to change.
Comment #12
kuldeep_mehra27 commentedComment #13
kuldeep_mehra27 commentedComment #14
jungle@kuldeep_mehra27 Thank you for working on this.
Would be great attaching an interdiff always if it's applicable. See "Creating an interdiff" https://www.drupal.org/documentation/git/interdiff
Comment #16
vsujeetkumar commentedMore test fixes
Comment #17
jungleThanks @vsujeetkumar!
No newline at end of file
Comment #18
vsujeetkumar commentedMore test fixes, Please review.
Comment #19
jungleUnfortunately, I think this one is duplicate with #2821499: Enable phpcs rule DrupalPractice.InfoFiles.NamespacedDependency, which was filed earlier than this. It expected the scope in the middle as well, I will go and change its title.
Thanks all for your efforts! Let's move to that issue and continue!