Comments

swatichouhan012 created an issue. See original summary.

swatichouhan012’s picture

Assigned: swatichouhan012 » Unassigned
Status: Active » Needs review
StatusFileSize
new409 bytes

Kindly review patch.

jungle’s picture

Title: All dependencies must be prefixed with the project name, in rdf module. » All dependencies must be prefixed with the project name
Component: rdf.module » other

I found following info.yml files having such an issue too. And I think it's ok to enlarge the scope to the whole codebase.


# layout_builder_views_test.info.yml
dependencies:
  - views

# new_dependency_test.info.yml
dependencies:
  - new_dependency_test_with_service

# form_test.info.yml
dependencies:
  - file
  - filter

# user_batch_action_test.yml
dependencies:
  - views
  - user
jungle’s picture

Version: 9.0.x-dev » 8.9.x-dev
Assigned: Unassigned » jungle
jungle’s picture

Assigned: jungle » Unassigned
StatusFileSize
new2.44 KB
jungle’s picture

StatusFileSize
new2.99 KB
+++ b/core/modules/migrate_drupal_multilingual/migrate_drupal_multilingual.info.yml
@@ -4,4 +4,4 @@ description: 'Provides a requirement for multilingual migrations.'
 package: 'Core (Experimental)'
 core: 8.x
 dependencies:
-  - migrate_drupal
+  - drupal:migrate_drupal

barone’s picture

StatusFileSize
new170.39 KB

The patch failed to alter one of the files: core/modules/migrate_drupal_multilingual/migrate_drupal_multilingual.info.yml with the error message:

Hunk #1 FAILED at 4.
1 out of 1 hunk FAILED -- saving rejects to file core/modules/migrate_drupal_multilingual/migrate_drupal_multilingual.info.yml.rej

patch error

Contents of that .rej file are:

***************
*** 4,7 ****
package: 'Core (Experimental)'
core: 8.x
dependencies:
- - migrate_drupal
--- 4,7 ----
package: 'Core (Experimental)'
core: 8.x
dependencies:
+ - drupal:migrate_drupal

barone’s picture

For all the other 4 files, i can confirm the patch worked as expected.

  • core/modules/rdf/tests/rdf_test/rdf_test.info.yml
  • core/modules/system/tests/modules/form_test/form_test.info.yml
  • core/modules/system/tests/modules/new_dependency_test/new_dependency_test.info.yml
  • core/modules/views/tests/modules/user_batch_action_test/user_batch_action_test.info.yml
jungle’s picture

StatusFileSize
new3 KB

@barone, Thanks for reviewing! Patch rerolled.

jungle’s picture

StatusFileSize
new2.99 KB
new3.21 KB

Patches for 8.8.x, and 9.0.x

quietone’s picture

Issue summary: View changes
Status: Needs review » Needs work

Thanks for the work on tidying this up.

However, there is no evidence here that all the info.yml files are fixed. So I tried this `grep -r -A20 --include="*.info.yml" 'dependencies:' | grep ' - ' | grep -v 'drupal:' ` which results in

     1  core/modules/help_topics/tests/modules/help_topics_test/help_topics_test.info.yml
     2  core/modules/system/tests/themes/test_theme_depending_on_constrained_modules/test_theme_depending_on_constrained_modules.info.yml
     3  core/modules/system/tests/themes/test_theme_depending_on_modules/test_theme_depending_on_modules.info.yml
     4  core/modules/system/tests/themes/test_theme_depending_on_nonexisting_module/test_theme_depending_on_nonexisting_module.info.yml
     5  core/modules/system/tests/themes/test_theme_mixed_module_dependencies/test_theme_mixed_module_dependencies.info.yml
     6  core/profiles/demo_umami/modules/demo_umami_content/demo_umami_content.info.yml
     7  core/profiles/testing_install_profile_all_dependencies/testing_install_profile_all_dependencies.info.yml
     8  core/profiles/testing_install_profile_dependencies/testing_install_profile_dependencies.info.yml

It may not be the most elegant of commands but it does find that there are more info files to change.

kuldeep_mehra27’s picture

Assigned: Unassigned » kuldeep_mehra27
kuldeep_mehra27’s picture

Assigned: kuldeep_mehra27 » Unassigned
Status: Needs work » Needs review
StatusFileSize
new8.66 KB
jungle’s picture

@kuldeep_mehra27 Thank you for working on this.

Would be great attaching an interdiff always if it's applicable. See "Creating an interdiff" https://www.drupal.org/documentation/git/interdiff

Status: Needs review » Needs work

The last submitted patch, 13: 3116077-13.patch, failed testing. View results

vsujeetkumar’s picture

Status: Needs work » Needs review
StatusFileSize
new8.61 KB
new1.44 KB

More test fixes

jungle’s picture

Status: Needs review » Needs work

Thanks @vsujeetkumar!

+++ b/core/profiles/testing_install_profile_all_dependencies/testing_install_profile_all_dependencies.info.yml
@@ -12 +12 @@
+  - drupal:stark
\ No newline at end of file

No newline at end of file

vsujeetkumar’s picture

Status: Needs work » Needs review
StatusFileSize
new9.4 KB
new2.08 KB

More test fixes, Please review.

jungle’s picture

Status: Needs review » Closed (duplicate)
Related issues: +#2821499: Enable phpcs rule DrupalPractice.InfoFiles.NamespacedDependency

Unfortunately, I think this one is duplicate with #2821499: Enable phpcs rule DrupalPractice.InfoFiles.NamespacedDependency, which was filed earlier than this. It expected the scope in the middle as well, I will go and change its title.

Thanks all for your efforts! Let's move to that issue and continue!