Make sure this module works when JSON:API schema is installed.

Requires #3093033: TopLevelSchemaLinkProviderBase::getLink breaks on custom route.

CommentFileSizeAuthor
#9 3116031-9.patch4.65 KBmglaman
#3 3116031-2.patch1001 bytesmglaman

Comments

mglaman created an issue. See original summary.

mglaman’s picture

mglaman’s picture

Status: Active » Needs review
StatusFileSize
new1001 bytes

Forgot the patch.

Status: Needs review » Needs work

The last submitted patch, 3: 3116031-2.patch, failed testing. View results

mglaman’s picture

mglaman’s picture

Issue summary: View changes
mglaman’s picture

JSON:API Schema had a release with the required fix. Rerunning tests

mglaman’s picture

Failure is due to the fact we now have the describedby link

--- Expected
+++ Actual
@@ @@
     'links' => Array (
         'shipping-methods' => Array (...)
         'self' => Array (...)
+        'describedby' => Array (...)
     )
 )
mglaman’s picture

Status: Needs work » Needs review
StatusFileSize
new4.65 KB

After adding the new link there was an error on the shipping methods route. This information is now in the order meta, so maybe it's not even needed.

  • mglaman committed a0853cd on 8.x-1.x
    Issue #3116031 by mglaman: Add integration tests with JSON:API Schema
    
mglaman’s picture

Status: Needs review » Fixed

Fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.