Kaltura Video Embed Field is a submodule of Video Embed Field for Kaltura Video support.
This module accepts and converts the Kaltura video URL to Kaltura video embedded format.

Demonstration: https://drive.google.com/file/d/1clr0KW33ky2Ce1Yp5wXDvXeyItdPloQD/view

Project Link

https://www.drupal.org/project/video_embed_kaltura

Git Instructions

git clone --branch 8.x-1.x https://git.drupalcode.org/project/video_embed_kaltura.git

PAReview checklist

https://pareview.sh/pareview/https-git.drupal.org-project-video_embed_ka...

Comments

Abhinand Gokhala K created an issue. See original summary.

abhinand gokhala k’s picture

Title: Review video_embed_kaltura D8 » [D8] Kaltura Video Embed Field
ankush_03’s picture

Issue summary: View changes
ankush_03’s picture

Added PAReview checklist link.

rksyravi’s picture

Issue summary: View changes
Status: Active » Needs review

Hi @Abhinand Gokhala K,

Thank you for contribution!!!

rksyravi’s picture

Hi @Abhinand Gokhala K,

From the below function, I can see that you're setting partner_id, uiconf_id in the configuration and also providing the config form to change these values. Is this are the dummy or trail data or the placeholder for the textfield.
* If trail, what happens when the trial ends.
* If placeholder then directly add placeholder properties to textfield.

I'll recommend not save in the configuration while installing instead provide these details in the documentation.

function video_embed_kaltura_install() {

  // Kaltura default configuration.
  $config = \Drupal::configFactory()->getEditable('video_embed_kaltura.kaltura_config');
  $config->set('partner_id', 811441);
  $config->set('uiconf_id', 32783592);
  $config->save();
}
avpaderno’s picture

Issue tags: -For the security advisory coverage
kaltura settings:
  title: 'Kaltura video settings'

The permissions should start with a verb, as in change own username or administer user settings.

abhinand gokhala k’s picture

@rksyravi We have set a default value (Provided by Kaltura) as Kaltura guest for the partner_id, uiconf_id.
If the module user has the Kaltura account then they can change the value.

abhinand gokhala k’s picture

@kiamlaluno I have created and fixed the issue https://www.drupal.org/project/video_embed_kaltura/issues/3116140

vuil’s picture

Status: Needs review » Reviewed & tested by the community

Thank you for the contribution!

I have not found any security related issue into the code.
I set the issue status to Reviewed & tested by the community.

abhinand gokhala k’s picture

Thanks Vuil

avpaderno’s picture

Assigned: Unassigned » avpaderno
Status: Reviewed & tested by the community » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

abhinand gokhala k’s picture

Thanks all, for your support.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.