Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
25 Feb 2020 at 05:22 UTC
Updated:
15 Mar 2020 at 06:49 UTC
Jump to comment: Most recent
Comments
Comment #2
abhinand gokhala k commentedComment #3
ankush_03Comment #4
ankush_03Added PAReview checklist link.
Comment #5
rksyraviHi @Abhinand Gokhala K,
Thank you for contribution!!!
Comment #6
rksyraviHi @Abhinand Gokhala K,
From the below function, I can see that you're setting
partner_id, uiconf_idin the configuration and also providing the config form to change these values. Is this are the dummy or trail data or the placeholder for the textfield.* If trail, what happens when the trial ends.
* If placeholder then directly add placeholder properties to textfield.
I'll recommend not save in the configuration while installing instead provide these details in the documentation.
Comment #7
avpadernoThe permissions should start with a verb, as in change own username or administer user settings.
Comment #8
abhinand gokhala k commented@rksyravi We have set a default value (Provided by Kaltura) as Kaltura guest for the partner_id, uiconf_id.
If the module user has the Kaltura account then they can change the value.
Comment #9
abhinand gokhala k commented@kiamlaluno I have created and fixed the issue https://www.drupal.org/project/video_embed_kaltura/issues/3116140
Comment #10
vuilThank you for the contribution!
I have not found any security related issue into the code.
I set the issue status to Reviewed & tested by the community.
Comment #11
abhinand gokhala k commentedThanks Vuil
Comment #12
avpadernoThank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank all the dedicated reviewers as well.
Comment #13
abhinand gokhala k commentedThanks all, for your support.